Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajout simplifié d'une convention finalisée - étape 1: sélection de l'opération #1268

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Ajout simplifié d'une convention finalisée - étape 1: sélection de l'opération #1268

merged 8 commits into from
Feb 29, 2024

Conversation

etchegom
Copy link
Contributor

@etchegom etchegom commented Feb 28, 2024 •
edited
Loading

@etchegom etchegom self-assigned this Feb 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7985 6443 81% 72% 🟢

New Files

File Coverage Status
conventions/forms/convention_form_add.py 100% 🟢
conventions/services/add_from_operation.py 90% 🟢
conventions/views/convention_form_add_from_operation.py 70% 🟢
TOTAL 87% 🟢

Modified Files

File Coverage Status
conventions/urls.py 100% 🟢
siap/siap_client/client.py 51% 🟢
users/models.py 91% 🟢
TOTAL 81% 🟢

updated for commit: 7041ae3 by action🐍

@etchegom etchegom marked this pull request as ready for review February 28, 2024 16:59
@etchegom etchegom requested a review from a team as a code owner February 28, 2024 16:59
@etchegom etchegom requested review from kolok and syldb and removed request for a team February 28, 2024 16:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

syldb
syldb approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@syldb syldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested that the flag hides the button, and the basic working scenario.

@etchegom etchegom merged commit e55f9b2 into main Feb 29, 2024
8 checks passed
@etchegom etchegom deleted the add-convention branch February 29, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syldb syldb syldb approved these changes

@kolok kolok Awaiting requested review from kolok kolok is a code owner automatically assigned from MTES-MCT/apilos

Assignees

@etchegom etchegom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etchegom @syldb