Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permettre les champs vide dans l'admin du model Programme #1562

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Conversation

kolok
Copy link
Collaborator

@kolok kolok commented Sep 3, 2024

Je me suis retrouvé couincé quand j'ai tenté de corriger un programme :

CleanShot 2024-09-03 at 20 47 33@2x

Cette PR ne corrige que l'admin de l'app programme, il y a surment d'autres modeles à modifier

@kolok kolok requested a review from a team as a code owner September 3, 2024 18:48
@kolok kolok requested review from etchegom and syldb and removed request for a team September 3, 2024 18:48
@kolok kolok force-pushed the allow_blank branch 2 times, most recently from 56ddf31 to 376c6bf Compare September 3, 2024 19:06
Copy link

github-actions bot commented Sep 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8237 6839 83% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
programmes/models/models.py 97% 🟢
programmes/signals.py 100% 🟢
TOTAL 99% 🟢

updated for commit: 829c187 by action🐍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai du diviser la migration car elle ne se terminait jamais


class Migration(migrations.Migration):

atomic = False
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supression de la transction pour gagner en perf

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je suis en train d'exécuter les migrations en local FYI

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etchegom : C'est Ok pour toi pour les migrations ?

]

operations = [
migrations.RunSQL(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai extrait la mise à jour de la valeur par défaut pour les perf

)
uuid = models.UUIDField(default=uuid.uuid4, editable=False)
nom = models.CharField(max_length=255)
numero_operation = models.CharField(max_length=255, null=True)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suppression de null=True sur tout les champs de type texte suite à la recommandation de SonarCloud

programmes/signals.py Outdated Show resolved Hide resolved
Copy link
Contributor

@etchegom etchegom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarcloud bot commented Sep 4, 2024

@kolok kolok merged commit e8cbfb9 into main Sep 4, 2024
8 checks passed
@kolok kolok deleted the allow_blank branch September 4, 2024 11:58
@kolok kolok added the enhancement New feature or request label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants