Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout d'une pièce jointe aux évènements #1569

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Conversation

syldb
Copy link
Contributor

@syldb syldb commented Sep 5, 2024

Capture d’écran 2024-09-05 à 15 33 28 Capture d’écran 2024-09-05 à 15 33 39

@syldb syldb requested a review from a team as a code owner September 5, 2024 13:34
@syldb syldb requested review from kolok and etchegom and removed request for a team September 5, 2024 13:34
@syldb syldb marked this pull request as draft September 5, 2024 13:51
Copy link

github-actions bot commented Sep 10, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8245 6847 83% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
conventions/forms/evenement.py 100% 🟢
conventions/models/evenement.py 100% 🟢
conventions/views/conventions.py 61% 🟢
TOTAL 87% 🟢

updated for commit: 9e35150 by action🐍

@syldb syldb force-pushed the ajout-fichier-journal branch 2 times, most recently from 3c20757 to 59c71d5 Compare September 16, 2024 06:45
@syldb
Copy link
Contributor Author

syldb commented Sep 16, 2024

Le fail de Sonar Cloud ne me semble pas pertinent (j'ai factorisé du code et la ligne d'include se retrouve sur plusieurs fichiers, ce qu'il considère comme une duplication)

@syldb syldb marked this pull request as ready for review September 16, 2024 06:52
Copy link
Collaborator

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mini commentaire

conventions/views/conventions.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 26, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented Sep 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@syldb syldb merged commit 92a87b3 into main Sep 26, 2024
7 of 8 checks passed
@syldb syldb deleted the ajout-fichier-journal branch September 26, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants