-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choix date signature #1586
base: main
Are you sure you want to change the base?
Choix date signature #1586
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
8b2b082
to
1ef6f3e
Compare
1ef6f3e
to
a244f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mini commentaire
J'ai hate de voir la démo :)
conventions/views/conventions.py
Outdated
@@ -58,6 +59,8 @@ | |||
from upload.models import UploadedFile | |||
from upload.services import UploadService | |||
|
|||
path_to_sent = "conventions/sent.html" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path_to_sent = "conventions/sent.html" | |
template_sent = "conventions/sent.html" |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mais en vrai, je pense que cet écra ne sert à rien et on devrait revenir au récapitulatif avec une notification du succès de signature : qu'en pense tu ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai créé cette variable parce que sonarcloud se plaignait
Oui c'est une bonne idée
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En local, je n'ai pas vu mon document s'afficher, mais peut-être ma config est pourrie
ça vaut le coup d'utiliser django.messages
pour afficher une notification de succès de téléchargement
En local selon les docs je les vois ou pas, mais l'upload marche bizarrement en local. |
Quality Gate passedIssues Measures |
TODO: