-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration du mailer + messages asynchrones #1160
Conversation
107e46d
to
0f1c88e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1160 +/- ##
=========================================
Coverage 98.67% 98.67%
Complexity 1852 1852
=========================================
Files 368 368
Lines 8014 8014
=========================================
Hits 7908 7908
Misses 106 106 ☔ View full report in Codecov by Sentry. |
0f1c88e
to
4c7b540
Compare
4c7b540
to
535ccfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Juste une petite question
Et, est-ce qu'il y a une manip que je peux faire en local pour vérifier que tout est bien configuré ?
240037e
to
1b0df29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'approuve en avance (par rapport au compte Brevo en attente)
1b0df29
to
53bdb02
Compare
@florimondmanca suite à ton commentaire, j'ai repensé un peu le système; J'ai rajouté redis commander, qui permet de voir les messages (notamment ceux en erreur, dans une interface web) et j'ai mis supervisor pour gérer nos workers. Aussi, le fait que Brevo soit en attente n'est pas bloquant pour merger cette PR. C'est juste un reminder |
53bdb02
to
3467262
Compare
@mmarchois OK 👍 Je ne connaissais pas Redis Commander. |
## ---------------- | ||
## Supervision | ||
## ---------------- | ||
## | ||
|
||
supervisor_status: | ||
docker compose exec supervisor supervisorctl status | ||
|
||
supervisor_restart: | ||
docker compose exec supervisor supervisorctl restart messenger-worker:* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je chipote peut-être mais, puisque Supervisor est utilisé pour démarrer le worker messenger en local, quid de le traiter comme un détail d'implémentation ?
## ---------------- | |
## Supervision | |
## ---------------- | |
## | |
supervisor_status: | |
docker compose exec supervisor supervisorctl status | |
supervisor_restart: | |
docker compose exec supervisor supervisorctl restart messenger-worker:* | |
## ---------------- | |
## Workers (for local development) | |
## ---------------- | |
## | |
workers_status: | |
docker compose exec supervisor supervisorctl status | |
workers_restart: | |
docker compose exec supervisor supervisorctl restart messenger-worker:* | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok je traiterai ton retour dans la prochaine PR
Cette PR rajoute la configuration du mailer ainsi que la gestion asynchrone des messages, qui sera utilisée pour l'envoi d'email.
Todo :