Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge user tokens #1185

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Purge user tokens #1185

merged 2 commits into from
Jan 30, 2025

Conversation

mmarchois
Copy link
Collaborator

@mmarchois mmarchois commented Jan 30, 2025 •
edited
Loading

@mmarchois mmarchois self-assigned this Jan 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (48435fe) to head (b9ba043).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1185   +/-   ##
=========================================
  Coverage     98.93%   98.94%           
- Complexity     1946     1949    +3     
=========================================
  Files           390      391    +1     
  Lines          8390     8404   +14     
=========================================
+ Hits           8301     8315   +14     
  Misses           89       89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmarchois mmarchois force-pushed the feat/purge-user-tokens branch 3 times, most recently from 4a82457 to 236086d Compare January 30, 2025 10:36
florimondmanca
florimondmanca reviewed Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Propre

Mais je m'attendais à ce qu'on utilise le scheduling de Scalingo et ce n'est pas le cas ? À clarifier, risque de conflit sur cron.json ?

@mmarchois mmarchois force-pushed the feat/purge-user-tokens branch from 236086d to 85264ef Compare January 30, 2025 14:11
@mmarchois mmarchois merged commit c1fd257 into main Jan 30, 2025
6 checks passed
@mmarchois mmarchois deleted the feat/purge-user-tokens branch January 30, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees

@mmarchois mmarchois

Labels
To review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmarchois @codecov-commenter @florimondmanca