Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(textile): distribution step had no inland road transports added. #662

Closed
wants to merge 2 commits into from
Closed

fix(textile): distribution step had no inland road transports added. #662

wants to merge 2 commits into from

Conversation

n1k0
Copy link
Member

@n1k0 n1k0 commented Jul 11, 2024 •
edited
Loading

@n1k0 n1k0 force-pushed the fix/fix-empty-distribution-step-transports branch 2 times, most recently from 2c63133 to ee38d01 Compare July 11, 2024 13:53
@n1k0 n1k0 requested review from paulboosz and vjousse July 11, 2024 13:54
vjousse
vjousse approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@vjousse vjousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the rational behind this decision, but code wise it's ok 👍

src/Data/Textile/Step.elm Outdated Show resolved Hide resolved
@n1k0 n1k0 force-pushed the fix/fix-empty-distribution-step-transports branch from ee38d01 to 0a7ecd4 Compare August 12, 2024 12:31
@paulboosz
Copy link
Collaborator

I'm late to the party, this is obsolete no ?
I can see the 500 km of distribution in prod now :
Simulation

image

@n1k0
Copy link
Member Author

n1k0 commented Sep 5, 2024 •
edited
Loading

@paulboosz le pb existe quand tu choisis un transport par avion, auquel cas tu vois qu'il n'y a plus du tout de camion pour la distribution alors que ça devrait être le cas

Pour mémoire, cette carte est bloquée et en attente "d'arbitrage" par Vincent C. https://www.notion.so/Probl-me-de-calcul-d-impact-lors-de-l-tape-de-distribution-fd771b46eb464c53a9907a5658d46da9

@n1k0 n1k0 force-pushed the fix/fix-empty-distribution-step-transports branch from 0a7ecd4 to 3e26351 Compare September 9, 2024 09:22
@n1k0 n1k0 force-pushed the fix/fix-empty-distribution-step-transports branch from 3e26351 to 8715a4f Compare September 16, 2024 14:03
@n1k0 n1k0 mentioned this pull request Sep 19, 2024
Merged
@n1k0
Copy link
Member Author

n1k0 commented Sep 19, 2024

Superseded by #761

@n1k0 n1k0 closed this Sep 19, 2024
@n1k0 n1k0 deleted the fix/fix-empty-distribution-step-transports branch September 19, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjousse vjousse vjousse approved these changes

@paulboosz paulboosz Awaiting requested review from paulboosz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n1k0 @paulboosz @vjousse