Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data): New ingredients #814

Merged
merged 105 commits into from
Nov 20, 2024
Merged

chore(data): New ingredients #814

merged 105 commits into from
Nov 20, 2024

Conversation

ccomb
Copy link
Collaborator

@ccomb ccomb commented Oct 24, 2024

🔧 Problem

We're missing many ingredients.

🍰 Solution

Added ingredients and exported the impacts.

Along with the new ingredients, some other modifications that needed to be done to get a more reliable result:

  • The brightway search now makes sure there is only one result. This forces to use more precise search terms to find a process. If it's impossible to get only one results, setting the search field to the exact name of the process forces to select this exact process.
  • The full list of activities.json has also been adapted to this behaviour

Since the ingredients editor is used when adding ingredients, it also has been adapted and fixed:

  • It has been adapter to this search behaviour, and the local save button is disabled until the search term leads to a single result.
  • It also now allows to set empty ecosystemic services, which was needed while adding new ingredients
  • Some select fields of the ecosystemic services have been translated
  • A bug has been fixed regarding the new plural categories fields (process_category)

🏝️ How to test

Check that the new ingredients on the review app are what is expected (naming, impacts, identifier, etc.)

ecobalyse-private: ingredients

Ingredient editor and others added 30 commits July 25, 2024 09:20
c Veuillez saisir le message de validation pour vos modifications. Les lignes
display the ecoscore and columns with percentage
"name": "Winter pea, conventional, 15% moisture, at farm gate {FR} U",
"source": "Agribalyse 3.1.1",
"system_description": "AGRIBALYSE",
"name": "Lentils, dry, at farm (WFLDB)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Winter pea is replaced by Lentils. I guess it's more adapted to the id "lentils-uncooked-fr". Is there any explanation why we had winter pea before ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no information found about this choice

@@ -7550,7 +7516,7 @@
{
"categories": ["ingredient"],
"comment": "",
"displayName": "Blé tendre Hors UE Conv.",
"displayName": "Blé tendre UE Conv.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the id is soft-wheat-non-eu and we're changing the displayName from Hors UE to UE but the LCI stays Soft wheat GLO. Is that normal ?

(Now the displayName is incoherent with the id, we really need to go to uuid)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Julia has found the error and will fix it

@ccomb ccomb requested a review from JFraichou November 15, 2024 09:49
Copy link
Collaborator

@JFraichou JFraichou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed data/food/activities.json and fixed the soft-wheat-eu and the onion-dried.
Every changes has been listed and will be written down on a dedicated Notion card

Copy link
Collaborator

@paulboosz paulboosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the gsheet of the diff

Some changes, don't really know what's happening. Don't have the elements or the time to understand, so here's my approval
image

@ccomb ccomb merged commit cb5e131 into master Nov 20, 2024
7 checks passed
@ccomb ccomb deleted the ingredients branch November 20, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants