-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(data): New ingredients #814
Conversation
Also force to select a contributor
c Veuillez saisir le message de validation pour vos modifications. Les lignes
display the ecoscore and columns with percentage
"name": "Winter pea, conventional, 15% moisture, at farm gate {FR} U", | ||
"source": "Agribalyse 3.1.1", | ||
"system_description": "AGRIBALYSE", | ||
"name": "Lentils, dry, at farm (WFLDB)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Winter pea
is replaced by Lentils
. I guess it's more adapted to the id "lentils-uncooked-fr". Is there any explanation why we had winter pea before ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no information found about this choice
public/data/food/processes.json
Outdated
@@ -7550,7 +7516,7 @@ | |||
{ | |||
"categories": ["ingredient"], | |||
"comment": "", | |||
"displayName": "Blé tendre Hors UE Conv.", | |||
"displayName": "Blé tendre UE Conv.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the id is soft-wheat-non-eu
and we're changing the displayName from Hors UE
to UE
but the LCI stays Soft wheat GLO
. Is that normal ?
(Now the displayName is incoherent with the id, we really need to go to uuid)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Julia has found the error and will fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed data/food/activities.json and fixed the soft-wheat-eu
and the onion-dried
.
Every changes has been listed and will be written down on a dedicated Notion card
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the gsheet of the diff
Some changes, don't really know what's happening. Don't have the elements or the time to understand, so here's my approval
🔧 Problem
We're missing many ingredients.
🍰 Solution
Added ingredients and exported the impacts.
Along with the new ingredients, some other modifications that needed to be done to get a more reliable result:
search
field to the exactname
of the process forces to select this exact process.activities.json
has also been adapted to this behaviourSince the ingredients editor is used when adding ingredients, it also has been adapted and fixed:
local save
button is disabled until the search term leads to a single result.process_category
)🏝️ How to test
Check that the new ingredients on the review app are what is expected (naming, impacts, identifier, etc.)
ecobalyse-private: ingredients