Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data): Add irrigation to the Ecoinvent organic cotton #832

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

ccomb
Copy link
Collaborator

@ccomb ccomb commented Nov 18, 2024

🔧 Problem

The organic cotton is a EI-modified one with only irrigation added. It's impacts are hardcoded and not retrieved from either simapro or brightway.

🍰 Solution

Use the Ecoinvent organic cotton and add a strategy to add irrigation to it during import.

🚨 Points to watch/comments

This may only applies on brightway, as I'm unsure where to find the modified organic cotton in SimaPro. It would be great to first merge #822

🏝️ How to test

Run the make clean_data import_ecoinvent then check in brightway / EI 3.9.1 and EI 3.10 that the organic cotton has an irrigation in the technosphere.
Compare the new impact with the previous ones.

ecobalyse-data: organic_cotton

@ccomb ccomb changed the title Add irrigation to the Ecoinvent organic cotton chore(data): Add irrigation to the Ecoinvent organic cotton Nov 19, 2024
@paulboosz
Copy link
Collaborator

Maurine doesn't validate the change
image

@ccomb
Copy link
Collaborator Author

ccomb commented Nov 20, 2024

The change is not about the difference between conventional and organic cotton, it's just about adding irrigation to the organic cotton.

@ccomb
Copy link
Collaborator Author

ccomb commented Nov 21, 2024

@vjousse
Copy link
Collaborator

vjousse commented Nov 21, 2024

Tested locally, Fibre, cotton, organic {RoW}| fibre production, cotton, organic, ginning | Cut-off, U has the expected value of 0.75 for water.
241121_22-15-42
241121_21-56-23

@ccomb ccomb merged commit 1939b77 into master Nov 21, 2024
7 checks passed
@ccomb ccomb deleted the organic_cotton branch November 21, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants