[Tech] Optimisations #3713
Merged
[Tech] Optimisations #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numew
requested review from
emilschn,
hmeneuvrier and
sfinx13
and removed request for
emilschn and
hmeneuvrier
hmeneuvrier
reviewed
Feb 17, 2025
| foreach ($this->signalement->getAffectations() as $affectation) { | ||
| if (AffectationStatus::STATUS_WAIT->value === $affectation->getStatut() | ||
| || AffectationStatus::STATUS_ACCEPTED->value === $affectation->getStatut()) { | ||
| $partnerRecipientsFiltered = $this->getRecipientsPartner($affectation->getPartner()); | ||
| $partnerRecipients = $this->getRecipientsPartner($affectation->getPartner(), false); | ||
| $partner = $this->partnerRepository->getWithUserPartners($affectation->getPartner()); |
There was a problem hiding this comment.
Je n'ai pas compris pourquoi tu n'as pas juste fait
$partner = $affectation->getPartner();
There was a problem hiding this comment.
le $affectation->getPartner(); c'est ce qu'on avait avant : ca génère les requête de récupération unitaire, ici j'ai mis en place une requete avec select groupé et jointure dans le repository pour le contourner
|
hmeneuvrier
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#3711
Description
Quelques optimisations mineures pour régler une partie des alertes "bleues" qui remonte le plus souvent sur sentry
Changements apportés
Ajout d'un index sur la colonne cp_occupant du signalement. Permet d'accélerer d'un facteur 100 la requête de vérification de l'existence de doublon (draft =>signalement). Voir test sur une boucle lancant 50 de ses requêtes :
Préchargement de la liste de situations et critères à la visualisation d'un signalement BO afin d'éviter de les requeter unitairement
Mise en cache (15 minutes) du total de signalement pour les stats sur la homepage (la requête commence a ralentir, et on a pas besoin de temps réel)
Lors de la création/envoie de notifications suite à l'ajout d'un suivi (depuis BO ou FO) récupération de la liste des UserPartner et Partner d'un partenaire pour éviter de faire des reqûetes unitaire
Pré-requis
execute-migration name=Version20250214125623 direction=upTests