[Suivis] Refactorisation de l'envoi de mail pour l'acceptation, le refus et la fermeture des signalements #3715
+157
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmeneuvrier
reviewed
Feb 18, 2025
| || AffectationStatus::STATUS_WAIT->value === $affectation->getStatut() | ||
| || AffectationStatus::STATUS_ACCEPTED->value === $affectation->getStatut()) { | ||
| $partnerRecipientsMailItem = $this->getRecipientsPartner($affectation->getPartner()); | ||
| $partnerRecipientsInAppNotifItem = $this->getRecipientsPartner($affectation->getPartner(), false); |
There was a problem hiding this comment.
Plutôt que $affectation->getPartner(), utiliser ce qu'a fait @numew
$partner = $this->partnerRepository->getWithUserPartners($affectation->getPartner());
dans https://github.com/MTES-MCT/histologe/pull/3713/files
There was a problem hiding this comment.
Ok, c'est fait ; ainsi que le rebase !
emilschn
force-pushed
the
feature/3681-refacto-mails-suivis
branch
from
ba07d1a to
bc1cc43
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#3681
Description
Suite à la suppression de l'ActivityListener, refactorisation de l'envoi de mail lors de l'acceptation, le refus ou la fermeture de signalements.
Les mails étaient envoyés jusqu'à présent dans des événements.
On les envoie dans l'événement de création de suivi, comme pour les autres mails.
TNR