review: claire's review

frontend/src/domain/entities/map/constants.ts

@@ -45,13 +45,10 @@ export enum DistanceUnit {
 }
 
 export enum MapToolType {
- DASHBOARD = 'DASHBOARD',
  FILTERS = 'FILTERS',
  INTEREST_POINT = 'INTEREST_POINT',
  MEASUREMENT = 'MEASUREMENT',
- MEASUREMENT_MENU = 'MEASUREMENT_MENU',
- VESSEL_LABELS = 'VESSEL_LABELS',
- VESSEL_VISIBILITY = 'VESSEL_VISIBILITY'
+ MEASUREMENT_MENU = 'MEASUREMENT_MENU'
 }
 
 export enum OLGeometryType {

frontend/src/domain/shared_slices/Global.ts

@@ -1,7 +1,7 @@
 // TODO This slice should disappear in favor of `features/MainWindow/slice.ts` and "Map" feature should have its own slice.
 // TODO "Map" feature should have its own slice where we would transfer the related `display...` props.
 
-import { isDashboardEnabled } from '@features/missions/MissionForm/utils'
+import { isDashboardEnabled } from '@features/Dashboard/utils'
 import { createSelector, createSlice, type PayloadAction } from '@reduxjs/toolkit'
 
 import type { MapToolType } from '../entities/map/constants'

frontend/src/features/Dashboard/utils.ts

@@ -0,0 +1,6 @@
+import { isCypress } from '@utils/isCypress'
+
+export const isDashboardEnabled = () =>
+ isCypress()
+ ? window.Cypress.env('CYPRESS_FRONTEND_DASHBOARD') === 'true'
+ : import.meta.env.FRONTEND_DASHBOARD_ENABLED === 'true'

frontend/src/features/missions/MissionForm/utils.ts

@@ -20,10 +20,6 @@ export const isMissionAutoUpdateEnabled = () =>
  isCypress()
  ? window.Cypress.env('CYPRESS_MISSION_FORM_AUTO_UPDATE') === 'true'
  : import.meta.env.FRONTEND_MISSION_FORM_AUTO_UPDATE === 'true'
-export const isDashboardEnabled = () =>
- isCypress()
- ? window.Cypress.env('CYPRESS_FRONTEND_DASHBOARD') === 'true'
- : import.meta.env.FRONTEND_DASHBOARD_ENABLED === 'true'
 
 /**
  * should a Formik `onChange` event trigger `saveMission`.