feature(PublicMissionApi): add filter by controlUnits #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwih
requested review from
thoomasbro,
ivangabriele,
louptheron and
claire2212
louptheron
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
LGTM.
Perso j'essaie d'utiliser le moins possible des var pour éviter des effets de bords, je préfère un "early return", mais c'est du taste.
Je laise @thoomasbro / @claire2212 faire une review!
backend/src/main/kotlin/fr/gouv/cacem/monitorenv/domain/use_cases/missions/GetMissions.kt
Outdated
Show resolved
Hide resolved
claire2212
approved these changes
Dec 8, 2023
thoomasbro
approved these changes
Dec 8, 2023
Co-authored-by: Loup Theron <loup-rodney@hotmail.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ajout d'un filtre par controlUnits sur l'endpoint Missions de l'API publique.
J'ai choisi de faire le filtre au niveau du UseCase plutot que dans la query car elle est native, que je ne maitrise pas du tout ce format et que le temps presse avant que les premiers tests de RapportNav ne commencent.
Dîtes moi si c'est ok.