[Zones Administratives] Ajout des zones administratives #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
relancer |
VincentAntoine
approved these changes
Jan 26, 2024
thoomasbro
force-pushed
the
thomas/add-administrative-layers
branch
from
e0f948c to
40d9e77
Compare
claire2212
reviewed
Jan 31, 2024
| @@ -39,7 +39,7 @@ export const getAdministrativeLayersStyle = code => { | |||
| font: '12px Marianne', | |||
| overflow: true, | |||
| stroke: new Stroke({ color: 'rgba(255,255,255,0.4)', width: 2 }), | |||
| text: Layers.FAO.getZoneName(feature) | |||
| text: Layers.FAO.getZoneName && Layers.FAO.getZoneName(feature) | |||
There was a problem hiding this comment.
pourquoi cette vérification, comme la fonction est définie par nous-même on sait qu'elle existe non?
There was a problem hiding this comment.
oui mais TS non... j'ai pas réussi à faire autrement. Je me suis trompé dans le typing ?
claire2212
approved these changes
Jan 31, 2024
geoserver_init_layers.sh script is idempotent
thoomasbro
force-pushed
the
thomas/add-administrative-layers
branch
from
414419f to
89e8173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues