Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISSION] [FIX] Attacher les reportings à l'ouverture du formulaire de mission plutot qu'au changement de fenetre #1503

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

maximeperraultdev
Copy link
Collaborator

@maximeperraultdev maximeperraultdev commented Jun 25, 2024

Related Pull Requests & Issues


  • Tests E2E (Cypress)

What have I done

  • Déplacement de la mise à jour des signalements rattachés de la navigation entre onglets vers le formulaire des missions

@maximeperraultdev maximeperraultdev changed the title fix: Synchronize field update with save [MISSION] [FIX] Modification des champs puis sauvegarde Jun 25, 2024
@maximeperraultdev maximeperraultdev force-pushed the maxime/fix/synchronize_missions_fields branch 2 times, most recently from 1f441b5 to bd55a8d Compare July 11, 2024 08:17
@maximeperraultdev maximeperraultdev force-pushed the maxime/fix/synchronize_missions_fields branch 2 times, most recently from 6aa9237 to d9e38eb Compare September 19, 2024 07:48
@maximeperraultdev maximeperraultdev changed the title [MISSION] [FIX] Modification des champs puis sauvegarde [MISSION] [FIX] Attacher les reportings à l'ouverture du formulaire de mission plutot qu'au changement de fenetre Sep 19, 2024
@claire2212
Copy link
Collaborator

@maximeperraultdev je viens de tester et ça met une erreur en console
Capture d’écran 2024-09-19 à 13 28 58

Ce qui est bizarre c'est le dispatch comme ça qui n'est ni dans une fonction ni dans un useEffect, est qui est donc appelé à chaque re-render de fichier

Et sinon je me suis rendue compte que le bouton pour fermer la modal de rattachement d'un signalement ne fonctionne pas. Il manque la fonction dans le fichier AttachReportingToMissionModal.tsx. Dans le composant MapIntercation il faudrait ajouter onCncel={cancelReportingToAttach}

et la fonction :

  const cancelReportingToAttach = () => {
    dispatch(updateMapInteractionListeners(MapInteractionListenerEnum.NONE))
    dispatch(attachReportingToMissionSliceActions.setAttachedReportings(initialAttachedReportings))
  }

@maximeperraultdev maximeperraultdev force-pushed the maxime/fix/synchronize_missions_fields branch from d9e38eb to b65c3ab Compare September 19, 2024 12:47
@maximeperraultdev
Copy link
Collaborator Author

@claire2212 J'ai ajouté le fix pour annuler le rattachement des signalements et j'ai wrappé le dispatch dans un useEffect !

@claire2212
Copy link
Collaborator

@maximeperrault je viens de retester et ca ne fonctionne pas correctement.
J'ai créée une mission, j'ai voulu ajouter trois signalements en une seule fois, quand je retourne dans la mission, la timeline fait des trucs bizarres elle affiche/masque certains signalements sans fin

Enregistrement.de.l.ecran.2024-09-20.a.16.54.30.mov

@maximeperraultdev
Copy link
Collaborator Author

@claire2212 j'avais repéré un bug quand tu detache le signalement de la mission mais pas a ce point là. Je regardes apres les tableaux de bord.

dependabot bot and others added 11 commits September 24, 2024 08:59
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.2 to 5.4.6.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
…24 updates

Bumps the non-major-dependencies group with 23 updates in the /backend directory:

| Package | From | To |
| --- | --- | --- |
| [org.springframework.boot:spring-boot-starter-web](https://github.com/spring-projects/spring-boot) | `3.3.2` | `3.3.3` |
| [org.springframework.security:spring-security-oauth2-resource-server](https://github.com/spring-projects/spring-security) | `6.3.1` | `6.3.3` |
| [org.springframework.security:spring-security-oauth2-jose](https://github.com/spring-projects/spring-security) | `6.3.1` | `6.3.3` |
| [org.springframework.boot:spring-boot-starter-actuator](https://github.com/spring-projects/spring-boot) | `3.3.2` | `3.3.3` |
| [org.springframework.boot:spring-boot-starter-json](https://github.com/spring-projects/spring-boot) | `3.3.2` | `3.3.3` |
| [org.springframework.boot:spring-boot-starter-security](https://github.com/spring-projects/spring-boot) | `3.3.2` | `3.3.3` |
| [org.springframework.boot:spring-boot-starter-data-jpa](https://github.com/spring-projects/spring-boot) | `3.3.2` | `3.3.3` |
| [org.hibernate.orm:hibernate-spatial](https://github.com/hibernate/hibernate-orm) | `6.5.2.Final` | `6.6.0.Final` |
| [org.flywaydb:flyway-core](https://github.com/flyway/flyway) | `10.17.0` | `10.17.3` |
| org.flywaydb:flyway-database-postgresql | `10.17.0` | `10.17.3` |
| [org.springframework.boot:spring-boot-configuration-processor](https://github.com/spring-projects/spring-boot) | `3.3.2` | `3.3.3` |
| [org.jetbrains.kotlinx:kotlinx-serialization-json](https://github.com/Kotlin/kotlinx.serialization) | `1.7.1` | `1.7.2` |
| [org.http4k:http4k-client-apache](https://github.com/http4k/http4k) | `5.26.0.0` | `5.29.0.0` |
| [org.springframework.boot:spring-boot-starter-cache](https://github.com/spring-projects/spring-boot) | `3.3.2` | `3.3.3` |
| [org.springframework.boot:spring-boot-starter-log4j2](https://github.com/spring-projects/spring-boot) | `3.3.2` | `3.3.3` |
| [io.sentry:sentry](https://github.com/getsentry/sentry-java) | `7.13.0` | `7.14.0` |
| [org.springframework.boot:spring-boot-devtools](https://github.com/spring-projects/spring-boot) | `3.3.2` | `3.3.3` |
| [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc) | `42.7.3` | `42.7.4` |
| [org.springframework.security:spring-security-test](https://github.com/spring-projects/spring-security) | `6.3.1` | `6.3.3` |
| [org.springframework.boot:spring-boot-starter-test](https://github.com/spring-projects/spring-boot) | `3.3.2` | `3.3.3` |
| [org.springframework.boot](https://github.com/spring-projects/spring-boot) | `3.3.2` | `3.3.3` |
| [org.jetbrains.kotlin.plugin.allopen](https://github.com/JetBrains/kotlin) | `2.0.0` | `2.0.20` |
| [plugin.jpa](https://github.com/JetBrains/kotlin) | `2.0.0` | `2.0.20` |



Updates `org.springframework.boot:spring-boot-starter-web` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.3.2...v3.3.3)

Updates `org.springframework.security:spring-security-oauth2-resource-server` from 6.3.1 to 6.3.3
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](spring-projects/spring-security@6.3.1...6.3.3)

Updates `org.springframework.security:spring-security-oauth2-jose` from 6.3.1 to 6.3.3
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](spring-projects/spring-security@6.3.1...6.3.3)

Updates `org.springframework.boot:spring-boot-starter-actuator` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.3.2...v3.3.3)

Updates `org.springframework.boot:spring-boot-starter-json` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.3.2...v3.3.3)

Updates `org.springframework.boot:spring-boot-starter-security` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.3.2...v3.3.3)

Updates `org.springframework.boot:spring-boot-starter-data-jpa` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.3.2...v3.3.3)

Updates `org.hibernate.orm:hibernate-spatial` from 6.5.2.Final to 6.6.0.Final
- [Release notes](https://github.com/hibernate/hibernate-orm/releases)
- [Changelog](https://github.com/hibernate/hibernate-orm/blob/6.6.0/changelog.txt)
- [Commits](hibernate/hibernate-orm@6.5.2...6.6.0)

Updates `org.flywaydb:flyway-core` from 10.17.0 to 10.17.3
- [Release notes](https://github.com/flyway/flyway/releases)
- [Commits](flyway/flyway@flyway-10.17.0...flyway-10.17.3)

Updates `org.flywaydb:flyway-database-postgresql` from 10.17.0 to 10.17.3

Updates `org.springframework.boot:spring-boot-configuration-processor` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.3.2...v3.3.3)

Updates `org.jetbrains.kotlinx:kotlinx-serialization-json` from 1.7.1 to 1.7.2
- [Release notes](https://github.com/Kotlin/kotlinx.serialization/releases)
- [Changelog](https://github.com/Kotlin/kotlinx.serialization/blob/master/CHANGELOG.md)
- [Commits](Kotlin/kotlinx.serialization@v1.7.1...v1.7.2)

Updates `org.http4k:http4k-client-apache` from 5.26.0.0 to 5.29.0.0
- [Release notes](https://github.com/http4k/http4k/releases)
- [Changelog](https://github.com/http4k/http4k/blob/master/CHANGELOG.md)
- [Commits](http4k/http4k@5.26.0.0...5.29.0.0)

Updates `org.springframework.boot:spring-boot-starter-cache` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.3.2...v3.3.3)

Updates `org.springframework.boot:spring-boot-starter-log4j2` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.3.2...v3.3.3)

Updates `io.sentry:sentry` from 7.13.0 to 7.14.0
- [Release notes](https://github.com/getsentry/sentry-java/releases)
- [Changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md)
- [Commits](getsentry/sentry-java@7.13.0...7.14.0)

Updates `io.sentry:sentry-log4j2` from 7.13.0 to 7.14.0
- [Release notes](https://github.com/getsentry/sentry-java/releases)
- [Changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md)
- [Commits](getsentry/sentry-java@7.13.0...7.14.0)

Updates `org.springframework.boot:spring-boot-devtools` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.3.2...v3.3.3)

Updates `org.postgresql:postgresql` from 42.7.3 to 42.7.4
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](pgjdbc/pgjdbc@REL42.7.3...REL42.7.4)

Updates `org.springframework.security:spring-security-test` from 6.3.1 to 6.3.3
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](spring-projects/spring-security@6.3.1...6.3.3)

Updates `org.springframework.boot:spring-boot-starter-test` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.3.2...v3.3.3)

Updates `org.springframework.boot` from 3.3.2 to 3.3.3
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.3.2...v3.3.3)

Updates `org.jetbrains.kotlin.plugin.allopen` from 2.0.0 to 2.0.20
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](JetBrains/kotlin@v2.0.0...v2.0.20)

Updates `plugin.jpa` from 2.0.0 to 2.0.20
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](JetBrains/kotlin@v2.0.0...v2.0.20)

---
updated-dependencies:
- dependency-name: org.springframework.boot:spring-boot-starter-web
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.security:spring-security-oauth2-resource-server
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.security:spring-security-oauth2-jose
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.boot:spring-boot-starter-actuator
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.boot:spring-boot-starter-json
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.boot:spring-boot-starter-security
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.boot:spring-boot-starter-data-jpa
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.hibernate.orm:hibernate-spatial
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: non-major-dependencies
- dependency-name: org.flywaydb:flyway-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.flywaydb:flyway-database-postgresql
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.boot:spring-boot-configuration-processor
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.jetbrains.kotlinx:kotlinx-serialization-json
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.http4k:http4k-client-apache
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.boot:spring-boot-starter-cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.boot:spring-boot-starter-log4j2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: io.sentry:sentry
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: non-major-dependencies
- dependency-name: io.sentry:sentry-log4j2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.boot:spring-boot-devtools
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.security:spring-security-test
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.boot:spring-boot-starter-test
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.springframework.boot
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: org.jetbrains.kotlin.plugin.allopen
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: plugin.jpa
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps org.jlleitschuh.gradle.ktlint from 11.6.1 to 12.1.1.

---
updated-dependencies:
- dependency-name: org.jlleitschuh.gradle.ktlint
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps the non-major-dependencies group in /frontend with 7 updates:

| Package | From | To |
| --- | --- | --- |
| [@reduxjs/toolkit](https://github.com/reduxjs/redux-toolkit) | `2.0.0` | `2.2.7` |
| [@tanstack/react-table](https://github.com/TanStack/table/tree/HEAD/packages/react-table) | `8.20.1` | `8.20.5` |
| [dayjs](https://github.com/iamkun/dayjs) | `1.11.12` | `1.11.13` |
| [react-router](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router) | `6.26.0` | `6.26.1` |
| [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) | `6.26.0` | `6.26.1` |
| [ts-jest](https://github.com/kulshekhar/ts-jest) | `29.2.4` | `29.2.5` |
| [use-debounce](https://github.com/xnimorz/use-debounce) | `10.0.2` | `10.0.3` |

Updates `@reduxjs/toolkit` from 2.0.0 to 2.2.7
- [Release notes](https://github.com/reduxjs/redux-toolkit/releases)
- [Commits](reduxjs/redux-toolkit@v2.0.0...v2.2.7)

Updates `@tanstack/react-table` from 8.20.1 to 8.20.5
- [Release notes](https://github.com/TanStack/table/releases)
- [Commits](https://github.com/TanStack/table/commits/v8.20.5/packages/react-table)

Updates `dayjs` from 1.11.12 to 1.11.13
- [Release notes](https://github.com/iamkun/dayjs/releases)
- [Changelog](https://github.com/iamkun/dayjs/blob/v1.11.13/CHANGELOG.md)
- [Commits](iamkun/dayjs@v1.11.12...v1.11.13)

Updates `react-router` from 6.26.0 to 6.26.1
- [Release notes](https://github.com/remix-run/react-router/releases)
- [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router/CHANGELOG.md)
- [Commits](https://github.com/remix-run/react-router/commits/react-router@6.26.1/packages/react-router)

Updates `react-router-dom` from 6.26.0 to 6.26.1
- [Release notes](https://github.com/remix-run/react-router/releases)
- [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md)
- [Commits](https://github.com/remix-run/react-router/commits/react-router-dom@6.26.1/packages/react-router-dom)

Updates `ts-jest` from 29.2.4 to 29.2.5
- [Release notes](https://github.com/kulshekhar/ts-jest/releases)
- [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md)
- [Commits](kulshekhar/ts-jest@v29.2.4...v29.2.5)

Updates `use-debounce` from 10.0.2 to 10.0.3
- [Release notes](https://github.com/xnimorz/use-debounce/releases)
- [Changelog](https://github.com/xnimorz/use-debounce/blob/master/CHANGELOG.md)
- [Commits](https://github.com/xnimorz/use-debounce/commits)

---
updated-dependencies:
- dependency-name: "@reduxjs/toolkit"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: non-major-dependencies
- dependency-name: "@tanstack/react-table"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: dayjs
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: react-router
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: react-router-dom
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: ts-jest
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
- dependency-name: use-debounce
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-major-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mission] - Garder ouverts les formulaires d'actions (et infractions) pendant la navigation
3 participants