[Tableau de bord & brief] Ajout du bouton et du feature flag #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximeperraultdev
force-pushed
the
maxime/feat/1696/add_dashboard_button_to_map
branch
from
910aa23
to
c4bc697
Compare
claire2212
reviewed
Sep 13, 2024
| @@ -45,6 +45,7 @@ export enum DistanceUnit { | |||
| } | |||
|
|
|||
| export enum MapToolType { | |||
| DASHBOARD = 'DASHBOARD', | |||
There was a problem hiding this comment.
je n'aurais pas mis ça ici, il s'agit des boutons "outils" et non des boutons avec un menu. En plus je ne vois pas où tu l'utilises cette constante.
Et je pense que tu peux en profiter pour enlever VESSEL_LABELSet VESSEL_VISIBILITY qui ne sont utilisés nul part (ça doit venir de Fish)
There was a problem hiding this comment.
Au temps pour moi c'est du reliquat de ce que j'avais fait au début :/. Je retire les vessels
claire2212
reviewed
Sep 13, 2024
| @@ -20,6 +20,10 @@ export const isMissionAutoUpdateEnabled = () => | |||
| isCypress() | |||
| ? window.Cypress.env('CYPRESS_MISSION_FORM_AUTO_UPDATE') === 'true' | |||
| : import.meta.env.FRONTEND_MISSION_FORM_AUTO_UPDATE === 'true' | |||
| export const isDashboardEnabled = () => | |||
| isCypress() | |||
There was a problem hiding this comment.
pourquoi le mettre dans la feature des missions?
There was a problem hiding this comment.
Oula je ne pensais pas l'avoir mis là ^^
claire2212
reviewed
Sep 13, 2024
There was a problem hiding this comment.
J'ai repéré quelques comportement bizarres :
- Quand tu ouvres un signalement, que tu le réduis puis le ré-ouvres via le chevron, les boutons derrières le formulaire du signalement ne se décalent pas à droite. On y a donc plus accès.
- Quand tu ouvres le menu des tableaux de bord, puis que tu cliques sur le bouton pour créer un point d'intérêt ça ne ferme pas le menu des tableaux de bord
- Quand tu clique sur le bouton du compte (avec authent activée) ça fait pété l'affichage
maximeperraultdev
force-pushed
the
maxime/feat/1696/add_dashboard_button_to_map
branch
from
1fadffd
to
451f4ae
Compare
maximeperraultdev
force-pushed
the
maxime/feat/1696/add_dashboard_button_to_map
branch
from
451f4ae
to
3d7fc1d
Compare
claire2212
approved these changes
Sep 18, 2024
maximeperraultdev
deleted the
maxime/feat/1696/add_dashboard_button_to_map
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: Refactoring side buttons to make positioning relative
Related Pull Requests & Issues