[Unités] Fixe plusieurs bugs concernant l'affichage des bases sur la carte #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivangabriele
force-pushed
the
ivan/fix-muliple-base-issues
branch
2 times, most recently
from
67d6240 to
35a137a
Compare
…control unit list dialog
ivangabriele
force-pushed
the
ivan/fix-muliple-base-issues
branch
from
b4cf739 to
4636bc1
Compare
claire2212
reviewed
Nov 17, 2023
| <NameText>{controlUnit.name}</NameText> | ||
| <AdministrationText>{controlUnit.administration.name}</AdministrationText> | ||
| <NameText title={controlUnit.administration.name}>{controlUnit.name}</NameText> | ||
| <AdministrationText title={controlUnit.administration.name}>{controlUnit.administration.name}</AdministrationText> |
There was a problem hiding this comment.
pourquoi passer une prop title alors que tu ne t'en sers pas? (NameText et AdministrationText)
There was a problem hiding this comment.
Si le nom est trop long, il est tronqué via les ellipsis. Le title permet d'afficher le titre en passant la souris dessus.
claire2212
reviewed
Nov 17, 2023
| @@ -73,7 +73,7 @@ export function ReportingCard({ | |||
|
|
|||
| const closeReportingCard = useCallback(() => { | |||
| dispatch(reportingActions.setSelectedReportingIdOnMap(undefined)) | |||
| dispatch(removeOverlayCoordinatesByName(Layers.REPORTING_SELECTED.code)) | |||
| dispatch(removeOverlayCoordinatesByName(Layers.REPORTINGS.code)) | |||
claire2212
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues