Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Préavis – Passer les préavis auto en enregistrement manuel #3874

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

@ivangabriele ivangabriele changed the title Ivan/disable logbook pno auto saving Préavis – Passer les préavis auto en enregistrement manuel Nov 19, 2024
@ivangabriele ivangabriele marked this pull request as draft November 19, 2024 07:46
@ivangabriele ivangabriele marked this pull request as ready for review November 19, 2024 10:02
@ivangabriele ivangabriele force-pushed the ivan/disable-logbook-pno-auto-saving branch from cd024ee to ac8760f Compare November 19, 2024 10:03
Copy link

sonarcloud bot commented Nov 19, 2024

Copy link
Collaborator

@louptheron louptheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -23,7 +20,7 @@ type FormProps = Readonly<{
detail: PriorNotification.Detail
initialFormValues: PriorNotification.LogbookForm
}>
export function Form({ detail, initialFormValues }: FormProps) {
export function Form({ detail }: FormProps) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On peut enlever initialFormValues de FormProps ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants