Fix highlevel parameter in MusicExtractor, which couldn't be specified #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, specifying the highlevel parameter in the MusicExtractor constructor raised a RuntimeError exception because the value of `highlevel.svm_models` wasn't being set with the right type. Fixes MTG#1051
antlarr
added a commit
to antlarr/bard
that referenced
this pull request
Oct 2, 2020
This requires essentia to be patched with MTG/essentia#1052 in order to fix MTG/essentia#1051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the highlevel parameter in the MusicExtractor constructor
raised a RuntimeError exception because the value of
highlevel.svm_modelswasn't being set with the right type.
Since Pool::set doesn't support a vector of strings, this fixes the issue by
adding the paths passed as arguments one by one, so the resulting type
is
vector<string>.Fixes #1051