Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Tests for Tonal Extractor Algorithm #1403

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cvf-bcn-gituser
Copy link
Contributor

The Extractor folder contains unit tests for key, level, music, rhythm descriptors and tuning frequency. Until now the tonal extractor has had no unit tests.

The unit tests added use the same general "boiler plate" of assertion tests that are typical of an extractor (silent test, valid config, etc.) as well as some tests on real audio, with some variation on config parameters. There is scope for adding more output checks on the more complex outputs such as chords_histogram, chords_progression. etc.

The idea behind capturing reference values for "chord changes rate", "key strength" for given audio files, is to support future regression testing on algorithm optimization and also to provide values to compare with other libraries.

@cvf-bcn-gituser
Copy link
Contributor Author

cvf-bcn-gituser commented Feb 27, 2024

FYI: See above pull request @palonso , @dbogdanov , @ffont

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant