Remove unnecessary user field from geotag #1820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alastair
force-pushed
the
geotag-remove-user
branch
from
0405599 to
42b1b06
Compare
alastair
force-pushed
the
geotag-remove-user
branch
from
edd3b37 to
a782795
Compare
alastair
force-pushed
the
geotag-remove-user
branch
from
a782795 to
2dfc90d
Compare
Only a very small proportion of sounds have a geotag, and there can only be one geotag per sound. Therefore it makes more sense to put a sound reference on the geotag instead of a geotag on the sound model which is almost always null. This should reduce the size of the sounds table
alastair
force-pushed
the
geotag-remove-user
branch
from
2dfc90d to
b6c2021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
Fixes #1036
Description
The
geotag.userfield just replicated the same value that was insound.user, no need to keep it.This PR additionally moves the relation between a sound and a geotag from the sound table to the geotag table. Because not all sounds have a geotag, we had a column which was 95% null. By adding a geotag.sound_id column to the geotag table, we can remove an entire column from Sound.
The sound_id field is marked as unique, so we can still only have one tag per sound and the query to join the two tables is more or less the same
Deployment steps:
Includes migration