Patches (circular imports and fixing broken tests) #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- following the changes made in mth5 testing, namely switch to miniconda
- tried adding a line i found in simpeg/pydiso#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am trying to add typehinting to
auroraand doing this has revealed some circular imports betweenauroraandmtpy-v2. I added a try/except to handle this.But then, ...
The tests in mtpy broke recently. This is something to do with anaconda I think ... I looked at the test changes to mth5 and brought them over to mtpy. A few other things had to be added because we build an environment in the mtpy tests.
Now they run, and are mostly passing but the few leftover tests will need the updates from the
featuresbranches currently being worked on, so I want to merge the changes here intofeatures.Alas, true test fixing will require addressing of mt_metadata issue 253. I added a workaround for now. The remaining failing test passes on my local system, but fails due to interpolating complex numbers.
@kujaku11 PTAL at the remaining test failures if you can.