HW3 - Ian Schwarzenberg #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbernet
requested changes
Feb 11, 2019
|
|
||
| console.log('Which games are owned by both Ross and Nathan', query7); | ||
|
|
||
| /* ===================== | ||
| Which games are exclusive to collections? In other words, only owned by either Ross or Nathan. | ||
| ===================== */ | ||
|
|
||
| var query8; | ||
| var query8 = _.difference(rossGameList, nathanGameList); //_.difference shows only the games that are not duplicated in either array (in other words, only the games that Ross and Nathan own on their own but not in common) |
There was a problem hiding this comment.
one difference alone is insufficient because it checks only one list against the other in one direction - it wouldn't capture games that only nathan owned in this case.
| @@ -26,8 +26,25 @@ | |||
| Start code | |||
|
|
|||
| ===================== */ | |||
|
|
|||
|
|
|||
| //BASICALLY OBTAINED FROM https://stackoverflow.com/questions/13845437/from-1-to-100-print-ping-if-multiple-of-3-pong-if-multiple-of-5-or-else-p: | |||
There was a problem hiding this comment.
It is fine, so long as you understand the results!
| @@ -98,7 +109,13 @@ | |||
|
|
|||
| ===================== */ | |||
|
|
|||
| var makeAMarker = (obj) => { //"obj" is the user input, in this case "obj" will be dataFiltered | |||
There was a problem hiding this comment.
I appreciate all of your comments. This is helpful
|
|
||
| for (var i=0; i <dataFiltered.length; i = i+1) { | ||
| makeAMarker(dataFiltered[i]).addTo(map) //Uses the makeAMarker function created above to add the points to the map | ||
| } |
There was a problem hiding this comment.
You did not attempt to "clean" the dirty data file. That is the really challenging part about this lab (and the main reason for my request for cleanup)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.