HW-ZIXUAN XU #16
Open
HW-ZIXUAN XU #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbernet
approved these changes
Feb 11, 2019
| else if (num % 5 === 0) { | ||
| console.log('Buzz') | ||
| } else console.log(num) | ||
| } |
There was a problem hiding this comment.
This does not log anything to the console. You need to initiate the loop.
|
|
||
| var result = num.reduce((accumulator, currentValue) => { | ||
| return accumulator + currentValue | ||
| }) |
There was a problem hiding this comment.
I think you got the right answer... but it's hard to tell based on the console log
|
|
||
| console.log('Which games are owned by both Ross and Nathan', query7); | ||
|
|
||
| /* ===================== | ||
| Which games are exclusive to collections? In other words, only owned by either Ross or Nathan. | ||
| ===================== */ | ||
|
|
||
| var query8; | ||
| var query8 = _.difference(rossGameList,nathanGameList); |
There was a problem hiding this comment.
difference is insufficient - it only works in one direction. This would not capture the games nathan has that I do not have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.