Some suggestion and example to fix this bug by dramatically update th…

…e Height of list JabRef#8823
MVP-D77 · May 27, 2022 · ef042e0 · ef042e0
1 parent 117bb1c
commit ef042e0
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.fxml b/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.fxml
@@ -9,7 +9,7 @@
 <?import org.jabref.gui.icon.JabRefIconView?>
 <fx:root xmlns:fx="http://javafx.com/fxml/1" type="HBox" xmlns="http://javafx.com/javafx/8.0.112"
          fx:controller="org.jabref.gui.fieldeditors.LinkedFilesEditor">
-    <ListView fx:id="listView" prefHeight="0" HBox.hgrow="ALWAYS" maxHeight="100" />
+    <ListView fx:id="listView" HBox.hgrow="ALWAYS"/>
     <Button onAction="#addNewFile"
             styleClass="icon-button">
         <graphic>

diff --git a/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.java b/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.java
@@ -236,7 +236,16 @@ public Parent getNode() {
 
     @FXML
     private void addNewFile() {
-        viewModel.addNewFile();
+//        System.out.println(listView.getPrefHeight());
+        int number = viewModel.addNewFile();
+        if(number < 3)
+            return;
+        else{
+            listView.setMinHeight(number*20);
+//            listView.setPrefHeight(number*5);
+            System.out.println(listView.getPrefHeight());
+        }
+//
     }
 
     @FXML

diff --git a/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java b/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
@@ -135,7 +135,7 @@ public ListProperty<LinkedFileViewModel> filesProperty() {
         return files;
     }
 
-    public void addNewFile() {
+    public int addNewFile() {
         Path workingDirectory = databaseContext.getFirstExistingFileDir(preferences.getFilePreferences())
                                                .orElse(preferences.getFilePreferences().getWorkingDirectory());
 
@@ -155,6 +155,7 @@ public void addNewFile() {
                     preferences,
                     externalFileTypes));
         });
+        return files.size();
     }
 
     @Override