Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyo3 stub chrono fix-Reentract check-BSCALE #86

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Conversation

gsleap
Copy link
Member

@gsleap gsleap commented Nov 11, 2024

No description provided.

@gsleap gsleap added the enhancement New feature or request label Nov 11, 2024
@gsleap gsleap requested a review from d3v-null November 11, 2024 01:58
@gsleap gsleap self-assigned this Nov 11, 2024
d3v-null added a commit to MWATelescope/Marlu that referenced this pull request Nov 11, 2024
d3v-null added a commit to MWATelescope/Marlu that referenced this pull request Nov 11, 2024
@d3v-null
Copy link
Contributor

Thanks @gsleap ! the bscale change has certainly fixed #85 , I'll do some more testing for #82

@d3v-null
Copy link
Contributor

#82 is fixed too!

cargo run --features=examples --example mwalib-print-corr-context -- --metafits /scratch/mwaeor/dev/nfdata/1061316664/raw/1061316664{.metafits,_20130823181046_gpubox01_00.fits}
    Finished dev [unoptimized + debuginfo] target(s) in 0.29s
     Running `target/debug/examples/mwalib-print-corr-context --metafits /scratch/mwaeor/dev/nfdata/1061316664/raw/1061316664.metafits /scratch/mwaeor/dev/nfdata/1061316664/raw/1061316664_20130823181046_gpubox01_00.fits`
Error: mwalib has been compiled with a CFITSIO library which was not built with the -DREENTRANT directive

Caused by:
    mwalib has been compiled with a CFITSIO library which was not built with the -DREENTRANT directive

@d3v-null d3v-null merged commit a8b0e7e into main Nov 12, 2024
64 checks passed
@d3v-null d3v-null deleted the pyo3_stub_chrono_fix branch November 12, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants