Skip to content
This repository has been archived by the owner on Jun 11, 2018. It is now read-only.

fixer for invalid var spacing #6

Closed
Ma27 opened this issue Apr 7, 2016 · 2 comments · Fixed by #21
Closed

fixer for invalid var spacing #6

Ma27 opened this issue Apr 7, 2016 · 2 comments · Fixed by #21
Assignees
@Ma27
Labels
Enhancement
Milestone
1.0.1

Comments

@Ma27
Copy link
Owner

Ma27 commented Apr 7, 2016

Description of the issue

The process of fixing such issues should be automated, therefore a fixer which repairs the wrong CS must be implemented.
@Ma27 Ma27 self-assigned this Apr 7, 2016
@Ma27 Ma27 added this to the 1.0.0 milestone Apr 7, 2016
@Ma27
Copy link
Owner Author

Ma27 commented Apr 19, 2016

closing as can't fix. All columns must be compared with each other, the current implementation simply compares the next two lines as this detects every violation thanks to the token lexer of ESLint.

@Ma27 Ma27 closed this as completed Apr 19, 2016
@Ma27 Ma27 removed the in progress label Apr 19, 2016
@Ma27 Ma27 removed this from the 1.0.0 milestone Apr 19, 2016
@Ma27 Ma27 mentioned this issue Apr 19, 2016
Closed
@Ma27 Ma27 removed the Can't Fix label Apr 22, 2016
@Ma27 Ma27 added this to the 1.0.1 milestone Apr 22, 2016
@Ma27 Ma27 reopened this Apr 22, 2016
@Ma27
Copy link
Owner Author

Ma27 commented Apr 22, 2016 •
edited
Loading

the multi-step validation is necessary for certain cases, so it requires an implementation and then this feature is possible :)

Ma27 added a commit that referenced this issue Apr 23, 2016
@Ma27
[#6 - #19 - #20] - tokenizer: improve algorithm by using a node-based…
ba8d509 
… approach instead of the token jumper

- fixes certain bugs with edge cases and special operators
- enables autofixing
@Ma27 Ma27 mentioned this issue Apr 23, 2016
Merged
Ma27 added a commit that referenced this issue Apr 23, 2016
@Ma27
[#6 - #19 - #20] - validation: improve SOC inside the validator and c…
955d1fd 
…olumn computation algorithm
@Ma27 Ma27 closed this as completed in #21 Apr 23, 2016
Ma27 added a commit that referenced this issue Apr 23, 2016
@Ma27
[#6 - #19 - #20] - tokenizer: improve algorithm by using a node-based…
d4e9e64 
… approach instead of the token jumper (#21)

- algorithm which detects declarations even better due to the newly implemented node scanning logic
- multiple node detections make the implementation of an autofixer possible
@Ma27 Ma27 removed the in review label Apr 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ma27 Ma27

Labels
Enhancement
Projects
None yet
Milestone
1.0.1
1 participant
@Ma27