Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hierarchical_topics: unused variable cluster_df significantly slowing down performance #1698

Closed
shadiakiki1986 opened this issue Dec 15, 2023 · 1 comment · Fixed by #1701
Closed

hierarchical_topics: unused variable cluster_df significantly slowing down performance #1698

shadiakiki1986 opened this issue Dec 15, 2023 · 1 comment · Fixed by #1701

Comments

@shadiakiki1986
Copy link
Contributor

The variable cluster_df seems not to be used anywhere in the function: https://github.com/MaartenGr/BERTopic/blob/master/bertopic/_bertopic.py#L1008

The groupby call in it is the slowest line in the function too.

Maybe better remove it
@MaartenGr
Copy link
Owner

Thanks! Should be indeed removed. If you want, a PR is appreciated. Otherwise, I'll put it on the list for next year.

shadiakiki1986 added a commit to shadiakiki1986/BERTopic that referenced this issue Dec 18, 2023
@shadiakiki1986
hierarchical_topics: remove unused variable cluster_df significantly …
840583f 
…slowing down performance (closes MaartenGr#1698)
@shadiakiki1986 shadiakiki1986 mentioned this issue Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hierarchical_topics: remove unused variable cluster_df significantly … shadiakiki1986/BERTopic
2 participants
@shadiakiki1986 @MaartenGr