-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _langchain.py with [KEYWORDS] tag option #1871
Conversation
keyword tag
Thanks for the PR! Could you perhaps make a brief mention in the docstrings that it only uses |
update docstring with KEYWORD tag use
Okay, I added a mention, let me know if that works. |
Awesome, LGTM! Quick question, have you tested how it works with vs. without the |
I don't have extensive testing, but:
Topics with keywordss:
Topics without keywords:
Do you need anything more? |
Thanks for testing! Could you perhaps do one last test using the same example but making sure that the same topics are created? You can do so by fixing the seed of UMAP. That way, it will be a fair comparison between two identical topics that only have different representations. |
Sure, included this umap model:
With Keywords:
Without keywords:
|
Awesome, it seems that there is a small difference between representations but that also be explained by simply the temperature since the differences seem minor. I can imagine that the difference becomes larger if somehow the documents are less representative or if there are more domain-specific keywords used that might not be present in the main documents. LGTM! Thank you for your work on this! |
Update langchain representation model with the inclusion to utilize topics keywords using the tag '[KEYWORDS]' in the prompt.