Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #1974

Merged
merged 2 commits into from
Jun 3, 2024
Merged

chore: fix typos #1974

merged 2 commits into from
Jun 3, 2024

Conversation

afuetterer
Copy link
Contributor

I did not create an issue first, because (again) the changes are trivial.

This PR fixes a few minor typos in docstrings and docs.

I used typos for this. You can also set up a pre-commit hook, so that all changes run through the spellchecker before commit.

I was unsure about this: typos wanted to change highligh_color() to highlight_color(), which is modifying the API. That is your decision.

def highligh_color(data, color='white'):

@afuetterer

This comment has been minimized.

Copy link
Owner

@MaartenGr MaartenGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these typos! I'll have to think about the package you refer since I rather manually check whether the changes are made correctly.

bertopic/_bertopic.py Outdated Show resolved Hide resolved
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the change here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was "Mutiply the IDF values of the seeded", missing l in multiply.

Co-authored-by: Maarten Grootendorst <maartengrootendorst@gmail.com>
@afuetterer
Copy link
Contributor Author

Of course, you don't need to use typos, I just wanted to let you know about the option.

I accepted your suggestion. Please feel free to squash the commits.

@MaartenGr MaartenGr merged commit 33eaaf7 into MaartenGr:master Jun 3, 2024
5 checks passed
@MaartenGr
Copy link
Owner

Awesome, thanks for the work on this!

@afuetterer afuetterer deleted the typos branch June 3, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants