Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: switch from setup.py to pyproject.toml #1978

Merged
merged 6 commits into from
Jun 5, 2024
Merged

build: switch from setup.py to pyproject.toml #1978

merged 6 commits into from
Jun 5, 2024

Conversation

afuetterer
Copy link
Contributor

@afuetterer afuetterer commented May 7, 2024 •
edited
Loading

See #1969

afuetterer
afuetterer commented May 14, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@afuetterer
Copy link
Contributor Author

What do you think?

@MaartenGr
Copy link
Owner

Thanks for the PR and the ping! There are several PRs/issues/discussions open that require my attention so it might take a while before I can explore this PR.

@afuetterer
Copy link
Contributor Author

Of course, sorry. :)

MaartenGr
MaartenGr reviewed May 23, 2024
View reviewed changes
Copy link
Owner

@MaartenGr MaartenGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of questions/suggestions that we can go over to make sure the general flow of installation remains the same.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@afuetterer

This comment was marked as outdated.

Sign in to view
afuetterer and others added 3 commits May 27, 2024 06:58
@afuetterer @MaartenGr
Update pyproject.toml
43297a0 
Co-authored-by: Maarten Grootendorst <maartengrootendorst@gmail.com>
@afuetterer @MaartenGr
Update pyproject.toml
71a9320 
Co-authored-by: Maarten Grootendorst <maartengrootendorst@gmail.com>
@afuetterer @MaartenGr
Update pyproject.toml
bb60223 
Co-authored-by: Maarten Grootendorst <maartengrootendorst@gmail.com>
@afuetterer afuetterer mentioned this pull request May 27, 2024
Closed
@freddyheppell freddyheppell mentioned this pull request Jun 3, 2024
Merged
4 tasks
@afuetterer
Copy link
Contributor Author

Will adapt soon.

@afuetterer
Copy link
Contributor Author

I think all requests are adapted. What do you think?

@MaartenGr
Copy link
Owner

Awesome, thank you for the work on this! LGTM 😄

@MaartenGr MaartenGr merged commit afebc6f into MaartenGr:master Jun 5, 2024
5 checks passed
@afuetterer afuetterer deleted the 1969-toml branch June 5, 2024 15:35
@afuetterer afuetterer mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaartenGr MaartenGr MaartenGr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afuetterer @MaartenGr