Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to chain strategy example in outlier_reduction.md #2065

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

reuning
Copy link
Contributor

@reuning reuning commented Jun 23, 2024

What does this PR do?

The chain strategies example in the outlier reduction has new_topics being acted on in the first step and then topics acted on in the second step. I'm pretty sure this is supposed to be other way around. This fixes that.

Before submitting

  • This PR fixes a typo or improves the docs (if yes, ignore all other checks!).
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes (if applicable)?
  • Did you write any new necessary tests?

@MaartenGr
Copy link
Owner

Yep, you are completely right! Thank you for the PR 😄

@MaartenGr MaartenGr merged commit 05c5ed9 into MaartenGr:master Jun 24, 2024
@reuning reuning deleted the patch-1 branch June 24, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants