fix 'cuml' w/ 'hdbscan' type checks in cluster/_utils.py
#981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This indeed should resolve any future HDBSCAN-like models to be implemented as well as custom models that do not yet support probability calculation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that current type checks in
bertopic/cluster/_utils.pyforcuml+hdbscanclusterers are incorrect.Since the "cuml" string is always evaluating to True (see lines 22, 34, and 45 in
bertopic/cluster/_utils.py), any subclass of HDBSCAN is triggering thecumlimport, raising anImportErrorwhen not installed. Even if installed, callingcuml_hdbscanmodule may not be adequate for all HDBSCAN subclasses.I'm opening this PR with a simple solution proposal, but feel free to find another way to fix this issue.