Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick jester from crewmates only #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Malarne
Copy link

@Malarne Malarne commented Dec 26, 2020

Made a small change to pick jester from crewmates only, simply by picking it from a list of players that are not impostor (cf code changes)
I didn't know if the gameplayers list was used somewhere else in the code, so i just kept it where it was.

@Maartii
Copy link
Owner

Maartii commented Dec 27, 2020

Hey! I appreciate you taking an interest in the plugin.

Did you test your code? I'm not sure if it would work, since the plugin currently assigns who will be jester as soon the host presses the play button and the countdown for the next game starts. At that point in time, it's not yet decided by the game who will be impostor (to my best knowledge at least).

@iwa
Copy link

iwa commented Dec 31, 2020

if it doesn't work, another solution could be to pick the jester after the beginning of the game, and sending the "you're the jester" message at the beginning and/or at the first meeting then?

@JohnTranQUT
Copy link

And another solution is the pick the Jester upon meeting, ignore the dead and impostor and notify at the 1st meeting.
Either way... I still think its best to make Jester optional. Not knowing whether you are or aren't Jester going into the game is kind of a big let down.

@Maartii
Copy link
Owner

Maartii commented Jan 1, 2021

Decided that I will just make a new version of the plugin where at the start of the game a meeting is called automatically for all players. And then the jester gets assigned in that very moment, so that the jester can be picked from crewmates only. Hope to be done within a week or so.

@iwa
Copy link

iwa commented Jan 2, 2021

would that be possible to reduce the voting / discussion time only for this meeting then? cause it would be better to call a meeting in which no ones could be voted out (but idk if that's possible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants