Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move clock init to free func, update examples #30

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

CBJamo
Copy link
Contributor

@CBJamo CBJamo commented May 7, 2024

Fixes #29

I feel like there should be a way to handle this that doesn't leave the footgun of forgetting the sd_init function, but I'm not sure how to do it.

CBJamo added 2 commits May 5, 2024 12:20
Add build profiles to 2040 example so defmt works right
Remove unnecessary deps from 2040 example
@avsaase
Copy link

avsaase commented Jul 15, 2024

One idea is to use a builder pattern where you first need to create an uninitialized SD card struct, call init on that struct and then you get the regular SD card struct.

Copy link
Owner

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very sorry about the delay in getting to this, I didn't have many spare cycles for this project over the summer.

With my one review comment, I'd accept this PR - but I'm curious as to how @avsaase's builder idea might work out.

Copy link
Owner

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev merged commit 4bfe7b1 into MabezDev:master Sep 12, 2024
1 check passed
This was referenced Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdspi no longer respects the sd spec startup sequence
3 participants