Skip to content
This repository has been archived by the owner on Apr 16, 2021. It is now read-only.

Move to github actions #15

Closed
wants to merge 5 commits into from
Closed

Move to github actions #15

wants to merge 5 commits into from

Conversation

mattip
Copy link

@mattip mattip commented Dec 18, 2020

Move x86 builds to github actions since travis.com has limited our use of their services. Also add a arm64 python3.9 build to travis, drop python3.6, and build only manylinux2010 and above wheels for 64-bit.

@mattip
Copy link
Author

mattip commented Dec 18, 2020

@janaknat when this is merged it should push arm64 wheels (and all the rest) to https://anaconda.org/scipy-wheels-nightly once a week.

@mattip mattip changed the title Semicolons Move to github actions Dec 18, 2020
@mattip
Copy link
Author

mattip commented Dec 18, 2020

There are failing tests on i686 and arm64

Any thoughts?

@janaknat
Copy link
Contributor

janaknat commented Dec 18, 2020

There are failing tests on i686 and arm64

* 2 failed on arm64 https://travis-ci.com/github/MacPython/matplotlib-wheels/jobs/462405783

* 37 failed on i686 when run on github actions https://github.com/MacPython/matplotlib-wheels/pull/15/checks?check_run_id=1576660778#step:7:3177

* 39 failed on i686 when run on travis https://travis-ci.com/github/MacPython/matplotlib-wheels/jobs/462405782#L3444

Any thoughts?

These aarch64 issues existed before the PR to change the upload process. Not really sure if it is an issue or a problem with tolerance.

Also, will these wheels be available on PyPI? You mentioned in the next release for matplotlib. Any dates that you are confident of for the release?

@tacaswell
Copy link
Contributor

We are aiming for 3.4 in January 21, but our relesae dates tend to be fluid.


Does anyone have access to an arm machine to look at the test failures? If this is due to slightly different float results we can probably safely increase the tolerances on those tests (which I suspect is the case for the 32bit architectures), however there is enough c++ in the code base I am concerned that we have something non-portable to arm. To diagnose that we need to at a minimum get the test images from a run on an arm machine (and best case someone who is willing to debug this having access to a live ARM machine!).

@janaknat
Copy link
Contributor

I can setup an EC2 m6g (arm64) instance for the test. Or if you prefer, I can help you set one up.

@janaknat
Copy link
Contributor

janaknat commented Jan 8, 2021

@tacaswell Are the aarch64 wheels on track to be released in the coming version?

@keewis
Copy link

keewis commented Feb 8, 2021

@tacaswell @QuLogic @mattip since they seem to require a bit more work, would it be possible to skip i386 / arm64 for now? It would be incredibly useful to be able to test with nightly versions again.

@tacaswell
Copy link
Contributor

We have moved wheel building to cibuildwheel and are now running it on GHA on the mpl repo. Thank you everyone for your work on this!

@tacaswell tacaswell closed this Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants