-
Notifications
You must be signed in to change notification settings - Fork 18
cibuildwheel for windows and travis #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2a27d39 to
327c4b9
Compare
|
Thanks! Rebased on top of #220 |
Co-authored by: nijincheng@iscas.ac.cn;
|
Hi @mattip. Could you temporarily disable Github Action for this PR? I may need to frequently commit to this branch to debug travis. If CI isn't disabled, it would waste CI resources. |
|
Sure, I disabled actions. Does the travis workflow work locally when run in a docker container with the appropriate |
Co-authored by: nijincheng@iscas.ac.cn;
Co-authored by: nijincheng@iscas.ac.cn;
…ecification in Travis CI Co-authored by: nijincheng@iscas.ac.cn;
It can run locally, but I tried it and encountered issues like illegal instruction errors. My local machine is fedora + x64. For s390x build, I running s390x containers with QEMU, illegal instruction problems are difficult to troubleshoot. What's even more troublesome is the environment issue - it's relatively difficult to reproduce the travis CI environment locally. For example, travis uses Python 3.10 by default. I just tested on travis and found that cibuildwheel 3.x doesn't actually support Python 3.10 (Or simply put, I didn't carefully check the documentation. ). I need more information before I can provide cibuildwheel support for travis. |
Co-authored by: nijincheng@iscas.ac.cn;
|
Now travis is fine, but due to some unknown reasons, same as before, two jobs failed at the very beginning. This might require reaching out to Travis maintainers for more help. We can now enable GitHub Actions for more testing. If there are any issues, please feel free to @ me directly. |
|
I re-enabled github CI and changed the macos-x86_64 build to run on macos-15-intel. Thanks for the progresss so far. |
|
@ffgan what would you think about keeping the windows builds separate from the posix ones? Many of the build steps are conditional anyway. Once we rationalize the batch vs. bash differences in the two windows builds, we can think about uniting the workflows. |
|
Is there a cibuildwheel option to get the logs to be open? It is frustrating to have to continually scroll to the end to get the next 30 lines in a thousand line log. |
Perhaps this link will be useful to you, https://cibuildwheel.pypa.io/en/stable/options/#build-verbosity |
I agree with your idea - compile-time errors are better than runtime errors. Let's try our best to figure out how to make the CI pass here. |
I found some possible issues and related PRs. I'm now testing whether the patches mentioned in them can be applied. |
|
Tou can change the OPENBLAS_COMMIT to develop which will pull in that PR and more |
see #211 (comment)
The CI results show that everything has passed. You can view the details at https://github.com/ffgan/openblas-libs/actions/runs/18747245828
I have merged the
winandwin on armconfigurations intoposix.ymland renamed that file towheel.yml.Regarding travis, since I cannot debug locally, I may add related commits in the PR to pass travis.
other info
Co-authored by: nijincheng@iscas.ac.cn;
git describe --tags --abbrev=8in OpenBLAS at theOPENBLAS_COMMIT. If I did not updateOPENBLAS_COMMIT, I incremented the wheel build number (i.e. 0.3.29.0.0 to 0.3.29.0.1)