This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
Update multibuild to the version that supports stripping wheels #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pv
reviewed
Feb 11, 2018
| @@ -10,6 +10,7 @@ OPENBLAS_VERSION=0.2.18 | |||
| source gfortran-install/gfortran_utils.sh | |||
|
|
|||
| function build_wheel { | |||
| export FFLAGS="$FFLAGS -fPIC -Wl,-strip-all" | |||
There was a problem hiding this comment.
Is -fPIC right on 32-bit platforms?
There was a problem hiding this comment.
Also, adding -Wl,-strip-all seems to be included in multibuild matthew-brett/multibuild@b2748e5 --- maybe we can bump the version to that commit instead and not set FFLAG here? Or maybe I'm missing something?
There was a problem hiding this comment.
-fPIC should work on all platform as far as I know.
That commit in multibuild only sets -Wl,-strip-all if no other FFLAGS are set, i.e. it supports that you can override the compile options if you don't want your things stripped. Thus we need to supply all flags here.
|
Thanks, seems to work fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25