Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

BLD: update to pybind11 2.4.3, fixes a segfault with SciPy 1.4.0 #61

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

tylerjereddy
Copy link
Collaborator

Wheels repo backport of #60 in preparation for SciPy 1.4.1.

See scipy/scipy#11237 and
pybind/pybind11#1262 for details.

tl;dr pybind11 is the first version where its symbol names are prefixed
with the GCC (or Clang) version it was compiled with.
@rgommers rgommers merged commit 094560e into MacPython:v1.4.x Dec 17, 2019
@rgommers
Copy link
Contributor

Merged, thanks @tylerjereddy. No need for this simply commit to run 5x for every PR, every merge, and then again for v1.4.1

@tylerjereddy tylerjereddy deleted the bump_pybind11 branch December 17, 2019 22:22
@pv
Copy link
Contributor

pv commented Dec 17, 2019

The openblas-libs rebuild just a moment ago changed openblas hashes, so they'd need to be updated.

@rgommers
Copy link
Contributor

Is that for the 64-bit BLAS? If so, wouldn't it be better to leave that out of v1.4.1?

@tylerjereddy
Copy link
Collaborator Author

The regular OpenBLAS got rebuilt as well as a side-effect I think, because I could not cancel those jobs. I probably should have just deleted the matrix entries but I was busy I guess & want to quickly provide those for the NumPy testing stuff.

@pv
Copy link
Contributor

pv commented Dec 17, 2019

Yes, the openblas-libs setup is a bit dangerous vs. overwriting existing artifacts (and several projects rely on those). Could maybe be better to add some "dev" env flag on the master branch (and file names?), and forbid the wheel uploader from replacing existing artifacts on non-dev builds.

@tylerjereddy
Copy link
Collaborator Author

In addition to the hashes I also see one fail for scipy.optimize.tests.test__differential_evolution.TestDifferentialEvolutionSolver.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants