Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add anaconda.org upload #97

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented Jan 5, 2022

No description provided.

@mattip
Copy link

mattip commented Jan 5, 2022

Ahh, cool! Once this works I can copy it for NumPy :) Did you need to do anything special with secrets?

@bashtage
Copy link
Contributor Author

bashtage commented Jan 5, 2022

I just copied the same that we have been using for the multibuild-based version. The only thing that I think needs to be done is to redirect them to the GITHUB_ENV , e.g., so that they can be used later.

echo "TOKEN=$MULTIBUILD_WHEELS_STAGING_ACCESS" >> $GITHUB_ENV

@bashtage bashtage force-pushed the add-upload branch 3 times, most recently from 4793538 to eb6aa4c Compare January 5, 2022 16:31
@bashtage bashtage merged commit dbf9d76 into MacPython:main Jan 5, 2022
@bashtage bashtage deleted the add-upload branch January 5, 2022 16:39
@mattip
Copy link

mattip commented Jan 5, 2022

The merged CI is failing with "ls: cannot access './wheelhouse/*.whl': No such file or directory"

@bashtage
Copy link
Contributor Author

bashtage commented Jan 5, 2022

I had a small typo above where I used ../wheelhouse instead of just wheelhouse. That code couldn't run until merged so hard to spot.

@mattip
Copy link

mattip commented Jan 5, 2022

Nice. I wonder why some of the wheeels (it seems the manylinux_2_17_x86_64.manylinux2014_x86_64 ones?) doubled in size

https://anaconda.org/multibuild-wheels-staging/statsmodels/files

@bashtage
Copy link
Contributor Author

bashtage commented Jan 5, 2022

Looks like cibuildwheel doesn't strip debug strings. Running strip -g on single .so file reduced it from 1.3MiB to around 250kiB.

@bashtage
Copy link
Contributor Author

bashtage commented Jan 5, 2022

@bashtage
Copy link
Contributor Author

bashtage commented Jan 5, 2022

See pypa/cibuildwheel#331

@bashtage
Copy link
Contributor Author

bashtage commented Jan 5, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants