Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Scoop package count performance #113

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Improve Scoop package count performance #113

merged 1 commit into from
Dec 30, 2021

Conversation

FantasyTeddy
Copy link
Contributor

As discussed in #107 I refactored the Scoop package count by using the SCOOP environment variable if available, or the default path C:\Users\<user>\scoop.

I am happy to say that this improved performance:

Note Mean [ms] Min [ms] Max [ms]
Before this PR 54.5 ± 7.6 50.6 104.5
PR without Scoop installed 43.0 ± 0.9 39.9 45.1
PR with Scoop installed 43.5 ± 0.9 41.5 46.3

@grtcdr
Copy link
Member

grtcdr commented Dec 30, 2021

Thank you Teddy :)

grtcdr
grtcdr requested changes Dec 30, 2021
View reviewed changes
src/windows/mod.rs Outdated Show resolved Hide resolved
src/windows/mod.rs Outdated Show resolved Hide resolved
grtcdr
grtcdr approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@grtcdr grtcdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🍨

@grtcdr grtcdr merged commit 18537f0 into Macchina-CLI:main Dec 30, 2021
@FantasyTeddy FantasyTeddy deleted the improve-scoop branch December 30, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grtcdr grtcdr grtcdr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FantasyTeddy @grtcdr