feat - make order that readout keys are listed in macchina.toml affec…

[Rolv-Apneseth]

…t the order readouts are displayed in.

Also minor change to the documentation to note that the order now matters.

Hope this is alright but of course don't hold back with criticisms / suggestions.

I'm still new to rust and wasn't sure how / if I should split up this file so I left everything in the one file but perhaps it's too long. Also I realise that this change makes the order have to matter rather than it being optional, if you would like it to be optional I can look into it, maybe add another config option for show_order_matters = "true".

Thanks for making this tool and thanks in advance for any feedback, I'm new to rust so any tips you have are appreciated.

[grtcdr]

That was quick!

Hope this is alright but of course don't hold back with criticisms / suggestions.

I went over the changes and they look fine to me, the one function per
readout pattern seems like our only way out, although we could benefit
from defining a macro to handle some of the boilerplate.

I'm still new to rust and wasn't sure how / if I should split up this
file so I left everything in the one file but perhaps it's too
long.

Good call, splitting them up even further doesn't seem all that
necessary.

Also I realise that this change makes the order have to matter
rather than it being optional, if you would like it to be optional I
can look into it, maybe add another config option for
show_order_matters = "true".

I think users will intuitively assume that the order in which
readouts appear matters and prefer it to keep it that way. If someone
doesn't care for the order, show_order_matters already doesn't
matter to them.

Thanks for making this tool and thanks in advance for any feedback,
I'm new to rust so any tips you have are appreciated.

Thank you for your help!

[Rolv-Apneseth]

I went over the changes and they look fine to me, the one function per
readout pattern seems like our only way out, although we could benefit
from defining a macro to handle some of the boilerplate.

Any idea how I could try to implement this? Macros are one thing I haven't really learned yet but what should it to do to help cut down on boilerplate?

[grtcdr]

I'm not really sure yet, I haven't had much experience using Rust's macro system.

EDIT: It seems the tiny variations between the different handlers would make the macro in question really complicated to implement.

[Rolv-Apneseth]

If the macro would be to complicated to implement, is there anything else you'd like from this pr or is that alright as is?

[grtcdr]

If the macro would be to complicated to implement, is there anything else you'd like from this pr or is that alright as is?

Nope, this is good enough for now.

Thank you for helping improve macchina :)