Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #1

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Develop #1

wants to merge 25 commits into from

Conversation

saihtaungkham
Copy link
Member

@saihtaungkham saihtaungkham commented Jan 18, 2020 •
edited by rhezaharliman
Loading

First commit for adding the functionalities of MLSearch API requesters.

Supported API Sources

  1. Paper with Code
  2. Github

rhezaharliman
rhezaharliman requested changes Jan 19, 2020
View reviewed changes
Copy link

@rhezaharliman rhezaharliman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, Sai! I checked it briefly. I wrote some comments. I think Shripad will take a look at it deeper.
Just CORS related that stuff that we might need to think about. Let's discuss it at the meeting. Thank you! 🙏

src/main/python/mlsearch/helper.py Outdated Show resolved Hide resolved
src/main/python/mlsearch/api_requester.py Outdated Show resolved Hide resolved
src/main/python/mlsearch/protocol.py Show resolved Hide resolved
saihtaungkham
saihtaungkham commented Jan 22, 2020
View reviewed changes
Copy link
Member Author

@saihtaungkham saihtaungkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. @rhezaharliman 🙏

src/main/python/mlsearch/api_requester.py Outdated Show resolved Hide resolved
src/main/python/mlsearch/helper.py Outdated Show resolved Hide resolved
src/main/python/mlsearch/protocol.py Show resolved Hide resolved
@rhezaharliman
Copy link

Thanks Sai. Looks good to me! May be Shripad wants to add something.

rhezaharliman
rhezaharliman approved these changes Feb 7, 2020
View reviewed changes
Copy link

@rhezaharliman rhezaharliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sai! Looks good to me. 😄

@rhezaharliman
Copy link

@saihtaungkham we might need to squash this commit b4b65cf 😅

@shripadtheneo if you have free time, would you mind to take a look at it? thank you very much beforehand 🙏

@saihtaungkham
Copy link
Member Author

b4b65cf
Oops... Private Access Token... 😅
I will try to fix this.

shripadtheneo and others added 12 commits May 6, 2020 22:17
@shripadtheneo @saihtaungkham
Initial commit for python egg for library of api requester
61d82bf 
Remove private access token
@saihtaungkham
Adding the functionalities to mlsearch package.
c724551
@saihtaungkham
Remove botocore as it seems to be removed by 2020/03.
0340e74
@saihtaungkham
Remove old readme file.
cf9aa10
@saihtaungkham
Fix rheza review comment.
59085f7
@saihtaungkham
Adding the POST request attributes.
1835db9
@saihtaungkham
Removing the IP_address attribute.
0c34b44
@saihtaungkham
Updating the readme.
c2f2970
@saihtaungkham
Adding and fixing the POST Attr missing.
89a3fd4
@saihtaungkham
Adding the last_page flag.
22eafc6
@saihtaungkham
Fixing the response format.
d1a020d
@saihtaungkham
Adding Youtube API.
704d579 
Modify Error Message

Update README.md

Update README.md

Update src/main/python/mlsearch/api_requester.py

Update src/main/python/mlsearch/api_requester.py

Update src/main/scripts/mlsearch

Update src/main/scripts/mlsearch

Update README.md

Update README.md

Update README.md

Update src/main/python/mlsearch/api_requester.py

Update src/main/python/mlsearch/api_requester.py

Update src/main/python/mlsearch/api_requester.py

Update src/main/python/mlsearch/api_requester.py

Update src/main/python/mlsearch/api_requester.py

Update README.md

Update src/main/python/mlsearch/api_requester.py

Update src/main/python/mlsearch/api_requester.py

Update src/main/python/mlsearch/api_requester.py

Update src/main/scripts/mlsearch

Update src/main/python/mlsearch/helper.py

Update src/main/python/mlsearch/helper.py

Update src/main/scripts/mlsearch

Update src/main/scripts/mlsearch

Update src/main/scripts/mlsearch

Update src/main/scripts/mlsearch

Fix missing source in youtube.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhezaharliman rhezaharliman rhezaharliman approved these changes

@shripadtheneo shripadtheneo Awaiting requested review from shripadtheneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saihtaungkham @rhezaharliman @shripadtheneo