Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add youtube api #4

Merged
merged 28 commits into from
Apr 14, 2020
Merged

Feature/add youtube api #4

merged 28 commits into from
Apr 14, 2020

Conversation

saihtaungkham
Copy link
Member

Adding new Youtube API feature.

  • next_page_token optional attribute has been added. Use this token for pagination in Youtube.
  • Fix some bug in Github Fetching API.
  • New attributes have been added in Protocol class in order to support Youtube API.

rhezaharliman
rhezaharliman requested changes Mar 11, 2020
View reviewed changes
Copy link

@rhezaharliman rhezaharliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sai! I reviewed it. Looks great! Please check my comments. 🙏

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/main/python/mlsearch/api_requester.py Outdated Show resolved Hide resolved
src/main/python/mlsearch/api_requester.py Outdated Show resolved Hide resolved
src/main/python/mlsearch/api_requester.py Show resolved Hide resolved
src/main/scripts/mlsearch Outdated Show resolved Hide resolved
src/main/scripts/mlsearch Outdated Show resolved Hide resolved
saihtaungkham
saihtaungkham commented Mar 11, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
saihtaungkham
saihtaungkham commented Mar 11, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
saihtaungkham
saihtaungkham commented Mar 11, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
saihtaungkham
saihtaungkham commented Mar 11, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
saihtaungkham
saihtaungkham commented Mar 11, 2020
View reviewed changes
Copy link
Member Author

@saihtaungkham saihtaungkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhezaharliman I have fixed according to your comments. Please check it out. Sorry for inline commit. I should have fixed it locally. 😰

rhezaharliman
rhezaharliman approved these changes Mar 12, 2020
View reviewed changes
Copy link

@rhezaharliman rhezaharliman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sai! Looks good to me. ( squash seems necessary 😅 )

@saihtaungkham saihtaungkham merged commit 1a0ba11 into develop Apr 14, 2020
@saihtaungkham saihtaungkham deleted the feature/add_youtube_api branch April 14, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhezaharliman rhezaharliman rhezaharliman approved these changes

@shripadtheneo shripadtheneo Awaiting requested review from shripadtheneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saihtaungkham @rhezaharliman