[SIEM] Adds 'Closes one signal when more than one opened signals are …

…selected' test again (elastic#60380) * Revert "Revert "adds new test (elastic#60064)"" This reverts commit 4a8fd0a. * waits for having 25 signals displayed
MadameSheema · Mar 17, 2020 · 63b339a · 63b339a
1 parent b2592e1
commit 63b339a
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 2 deletions.
diff --git a/x-pack/legacy/plugins/siem/cypress/integration/detections.spec.ts b/x-pack/legacy/plugins/siem/cypress/integration/detections.spec.ts
@@ -5,12 +5,14 @@
  */
 import {
   NUMBER_OF_SIGNALS,
+  OPEN_CLOSE_SIGNALS_BTN,
   SELECTED_SIGNALS,
   SHOWING_SIGNALS,
   SIGNALS,
 } from '../screens/detections';
 
 import {
+  closeFirstSignal,
   closeSignals,
   goToClosedSignals,
   goToOpenedSignals,
@@ -26,7 +28,7 @@ import { loginAndWaitForPage } from '../tasks/login';
 import { DETECTIONS } from '../urls/navigation';
 
 describe('Detections', () => {
-  before(() => {
+  beforeEach(() => {
     esArchiverLoad('signals');
     loginAndWaitForPage(DETECTIONS);
   });
@@ -53,6 +55,7 @@ describe('Detections', () => {
         waitForSignals();
         cy.reload();
         waitForSignals();
+        waitForSignalsToBeLoaded();
 
         const expectedNumberOfSignalsAfterClosing = +numberOfSignals - numberOfSignalsToBeClosed;
         cy.get(NUMBER_OF_SIGNALS)
@@ -111,4 +114,43 @@ describe('Detections', () => {
           .should('eql', expectedNumberOfOpenedSignals.toString());
       });
   });
+
+  it('Closes one signal when more than one opened signals are selected', () => {
+    waitForSignalsToBeLoaded();
+
+    cy.get(NUMBER_OF_SIGNALS)
+      .invoke('text')
+      .then(numberOfSignals => {
+        const numberOfSignalsToBeClosed = 1;
+        const numberOfSignalsToBeSelected = 3;
+
+        cy.get(OPEN_CLOSE_SIGNALS_BTN).should('have.attr', 'disabled');
+        selectNumberOfSignals(numberOfSignalsToBeSelected);
+        cy.get(OPEN_CLOSE_SIGNALS_BTN).should('not.have.attr', 'disabled');
+
+        closeFirstSignal();
+        cy.reload();
+        waitForSignalsToBeLoaded();
+        waitForSignals();
+
+        const expectedNumberOfSignals = +numberOfSignals - numberOfSignalsToBeClosed;
+        cy.get(NUMBER_OF_SIGNALS)
+          .invoke('text')
+          .should('eq', expectedNumberOfSignals.toString());
+        cy.get(SHOWING_SIGNALS)
+          .invoke('text')
+          .should('eql', `Showing ${expectedNumberOfSignals.toString()} signals`);
+
+        goToClosedSignals();
+        waitForSignals();
+
+        cy.get(NUMBER_OF_SIGNALS)
+          .invoke('text')
+          .should('eql', numberOfSignalsToBeClosed.toString());
+        cy.get(SHOWING_SIGNALS)
+          .invoke('text')
+          .should('eql', `Showing ${numberOfSignalsToBeClosed.toString()} signal`);
+        cy.get(SIGNALS).should('have.length', numberOfSignalsToBeClosed);
+      });
+  });
 });
diff --git a/x-pack/legacy/plugins/siem/cypress/screens/detections.ts b/x-pack/legacy/plugins/siem/cypress/screens/detections.ts
@@ -12,7 +12,9 @@ export const MANAGE_SIGNAL_DETECTION_RULES_BTN = '[data-test-subj="manage-signal
 
 export const NUMBER_OF_SIGNALS = '[data-test-subj="server-side-event-count"]';
 
-export const OPEN_CLOSE_SIGNALS_BTN = '[data-test-subj="openCloseSignal"] .siemLinkIcon__label';
+export const OPEN_CLOSE_SIGNAL_BTN = '[data-test-subj="update-signal-status-button"]';
+
+export const OPEN_CLOSE_SIGNALS_BTN = '[data-test-subj="openCloseSignal"] button';
 
 export const OPENED_SIGNALS_BTN = '[data-test-subj="openSignals"]';
 

diff --git a/x-pack/legacy/plugins/siem/cypress/tasks/detections.ts b/x-pack/legacy/plugins/siem/cypress/tasks/detections.ts
@@ -8,13 +8,20 @@ import {
   CLOSED_SIGNALS_BTN,
   LOADING_SIGNALS_PANEL,
   MANAGE_SIGNAL_DETECTION_RULES_BTN,
+  OPEN_CLOSE_SIGNAL_BTN,
   OPEN_CLOSE_SIGNALS_BTN,
   OPENED_SIGNALS_BTN,
   SIGNALS,
   SIGNAL_CHECKBOX,
 } from '../screens/detections';
 import { REFRESH_BUTTON } from '../screens/siem_header';
 
+export const closeFirstSignal = () => {
+  cy.get(OPEN_CLOSE_SIGNAL_BTN)
+    .first()
+    .click({ force: true });
+};
+
 export const closeSignals = () => {
   cy.get(OPEN_CLOSE_SIGNALS_BTN).click({ force: true });
 };