Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Frequent software freeze since 1.9.3 update #76

Merged
merged 5 commits into from
Jun 5, 2022
Merged

Fix: Frequent software freeze since 1.9.3 update #76

merged 5 commits into from
Jun 5, 2022

Conversation

DavidPhillipOster
Copy link

Pull request of OCRTracker.m, & OCRTracker.{h,m} that cancels OCR requests once their result is no longer needed. This fixes Frequent software freeze since 1.9.3 update #74
Tested with the Japanese document from @Patalliro8 - Before, after using next/previous to go all the way through the document and back a total of 4 times, I'd see the symptoms. After, RAM usage stays low, and responsiveness is still good.

@nickv2002
Copy link
Collaborator

Thanks! If this looks good to @MaddTheSane also we can merge and send to Apple.

@MaddTheSane MaddTheSane merged commit b9a1868 into MaddTheSane:arc Jun 5, 2022
@nickv2002
Copy link
Collaborator

nickv2002 commented Jun 5, 2022

Great, I've built this and sent to build over to Apple for a new release (version 1.9.4)

@Patalliro8
Copy link

Thank you very much for the fix!!
Is there any chance we may have an ability to turn off the Live Text feature entirely in the future?
I still seem to encounter the large memory usage and eventual freeze with version 1.9.4 (290).

@DavidPhillipOster
Copy link
Author

@Patalliro8 your bug reports have helped me get the bugs out of that feature - problems I'm not seeing. So if you have steps to reproduce, please file them as issues.
Before June 24 I will submit a pull request that adds a checkbox to preferences to turn the feature off. (You'd think that just adding a checkbox would be simple, but I have to cope with localization issues, with the user changing the state of that checkbox while in the middle of reading a book, and that feature powers future features I'm working on: a Find command, and Spotlight indexing.)

@DavidPhillipOster
Copy link
Author

#79 is a start. It will let you turn off the feature from Terminal even before there is a checkbox in the U.I.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frequent software freeze since 1.9.3 update
4 participants