New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/remove region enum #1300

Draft

folkzb wants to merge 2 commits into MagaluCloud:main from folkzb:feat/remove-region-enum

Collaborator

folkzb commented Dec 17, 2024 •

edited

Loading

What does this PR do?

This PR allows any region with object storage, making an s3 tool compatible

How Has This Been Tested?

Manually tested sending any region and works

TODO

Change the signingRegion to use sended region

Checklist

I have run Pre commit pre-commit run --all-files
My code follows the style guidelines of this project
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works

Screenshots/Videos

folkzb added 2 commits

December 13, 2024 18:13


          feat: remove region enum to use with any region

b380a7b


          run pre-commit

e346d92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet