Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unset command to remove object-lock configuration from buckets #1339

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

GuiLorencato
Copy link
Collaborator

@GuiLorencato GuiLorencato commented Jan 28, 2025

What does this PR do?

Implements the 'unset' command for removing object-lock configurations on buckets.
The command sends a PUT request with a customizable XML body to the specified bucket
URL, allowing different combinations of object-lock settings, such as disabling
lock retention or clearing rules.

Changes include:

Addition of the unset command logic and related parameter handling.
Dynamic XML body generation to accommodate different server requirements.
Logging adjustments to display the actual request body sent to the server.

How Has This Been Tested?

  • Unit Tests: Describe the unit tests you have written and their outcomes.

  • Integration Tests: Detail the integration tests performed and their results.

  • Manual Testing: Explain the manual testing process, including steps taken and evidence such as screenshots or logs.

Checklist

  • I have run Pre commit pre-commit run --all-files
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots/Videos

@GuiLorencato GuiLorencato requested a review from a team as a code owner January 28, 2025 12:26
@GuiLorencato GuiLorencato self-assigned this Jan 28, 2025
@GuiLorencato GuiLorencato added the cli cli related improvements label Jan 28, 2025
@luizcavalcanti luizcavalcanti merged commit 2f548ca into main Jan 30, 2025
5 checks passed
@luizcavalcanti luizcavalcanti deleted the feat/unset-object-locking branch January 30, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli cli related improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants