This repository has been archived by the owner on Apr 30, 2022. It is now read-only.
Implementation of WebDriverManager #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FermJacob
commented
Aug 24, 2021
|
Kudos, SonarCloud Quality Gate passed! |
|
Add additional unit tests to load all browsers and validate functionality on SeleniumConfig tests |
…om/Magenic/MAQS into feature/JacobFerm/WebDriverManager
…om/Magenic/MAQS into feature/JacobFerm/WebDriverManager
…om/Magenic/MAQS into feature/JacobFerm/WebDriverManager
TroyWalshProf
approved these changes
Oct 14, 2021
| @@ -223,6 +230,7 @@ public static IWebDriver GetFirefoxDriver(TimeSpan commandTimeout, FirefoxOption | |||
| { | |||
| return CreateDriver(() => | |||
| { | |||
| new DriverManager().SetUpDriver(new FirefoxConfig()); | |||
There was a problem hiding this comment.
Do we want to do this every single time we create a new driver?
Feels like we could just do it once.
I see 2 problems with this implementation.
- We pay a small cost for every single test
- If the remote gecko host (AKA where WebDriverManager downloads the driver from) goes done at any point in our test run we will likely start failing tests.
| @@ -248,6 +256,7 @@ public static IWebDriver GetEdgeDriver(TimeSpan commandTimeout, EdgeOptions edge | |||
| { | |||
| return CreateDriver(() => | |||
| { | |||
| new DriverManager().SetUpDriver(new EdgeConfig()); | |||
| var driver = new EdgeDriver(GetDriverLocation("MicrosoftWebDriver.exe", GetProgramFilesFolder("Microsoft Web Driver", "MicrosoftWebDriver.exe")), edgeOptions, commandTimeout); | |||
There was a problem hiding this comment.
I don't think this will work nicely outside windows.
Think :
var driver = new EdgeDriver(EdgeDriverService.CreateChromiumService() , edgeOptions, commandTimeout);
may work better.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #781
Closes #680