Update compliments.md

[3DPixel]

In the original guide, adding the compliments to the MagicMirror/config/config.js file didn't override the default compliments. By adding them to the defaults file, it works

[bugsounet]

adding the compliments to the MagicMirror/config/config.js file didn't override the default compliments.

Tested with new compliments in config.js, it's works
I think you have made an error in your personal config

There is maybe an error of understanding, I will clarify the doc

sample there

maybe it's better:

{
    module: "compliments",
    position: "lower_third",
    config: {
      compliments: {
        anytime: [
          "Hey there sexy!"
        ],
        morning: [
          "Good morning, handsome!",
          "Enjoy your day!",
          "How was your sleep?"
        ],
        afternoon: [
          "Hello, beauty!",
          "You look sexy!",
          "Looking good today!"
        ],
        evening: [
          "Wow, you look hot!",
          "You look nice!",
          "Hi, sexy!"
        ],
        "....-01-01": [
          "Happy new year!"
        ]
      }
    }
}

@rejas: what do you think about this ?

[rejas]

@bugsounet is right, the moduel works as expected, no need to change the defaults. happy to get a PR for this to clear up

[3DPixel]

I edited the config/compliments.js file and ran the npm check utility and everything checked out but none of the custom compliments worked and the defaults ran instead. From: Bugsounet - Cédric ***@***.***> Sent: Saturday, September 30, 2023 10:08 PM To: MichMich/MagicMirror-Documentation ***@***.***> Cc: 3DPixel ***@***.***>; Author ***@***.***> Subject: Re: [MichMich/MagicMirror-Documentation] Update compliments.md (PR #188) adding the compliments to the MagicMirror/config/config.js file didn't override the default compliments. Tested with new compliments in config.js, it's works I think you have made an error in your personal config There is maybe an error of understanding, I will clarify the doc sample there<https://develop.docs.magicmirror.builders/modules/compliments.html#default-value> maybe it's better: { module: "compliments", position: "lower_third", config: { compliments: { anytime: [ "Hey there sexy!" ], morning: [ "Good morning, handsome!", "Enjoy your day!", "How was your sleep?" ], afternoon: [ "Hello, beauty!", "You look sexy!", "Looking good today!" ], evening: [ "Wow, you look hot!", "You look nice!", "Hi, sexy!" ], "....-01-01": [ "Happy new year!" ] } } } @rejas<https://github.com/rejas>: what do you thiink about this ? — Reply to this email directly, view it on GitHub<#188 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGKWOMG7CVWGADLOAMEMUUDX5CCZHANCNFSM6AAAAAA5NXFMLI>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[bugsounet]

Configuration tested (in config/config.js)

		{
			module: "compliments",
			position: "lower_third",
			animateIn: "bounceInDown",
			animateOut: "bounceOutUp",
			config: {
				updateInterval: 500,
				fadeSpeed: 200,
				compliments: {
			          anytime: [
			            "anytime1",
			            "Really ?",
			            "there is not default!!!"
			          ],
			          morning: [
			            "morning1",
			            "morning2",
			            "morning3"
			          ],
			          afternoon: [
			            "afternoon1",
			            "afternoon2",
			            "afternoon3"
			          ],
			          evening: [
			            "evening1",
			            "evening2",
			            "evening3"
			          ],
			          "....-01-01": [
			            "!!!! Happy new year !!!!!"
			          ]
			       }
			}
			
		},

Result:

That you can see, there is no default and the module works as expected.
I just speed up interval of update

[rejas]

I edited the config/compliments.js file

Strange filename, you should edit config/config.js

[khassel]

what is the content beside the unwanted filename change? It's hard to see, looks like only format has changed (which will be reverted when lintered).

[3DPixel]

Apologies, it was the config/config.js I typed ‘compliements.js’ as I’d not got the details to hand and thought it was the right file name.. of the top of my head. Back to the original topic. I don’t know why it didn’t work for me, I had just copied the template from the documentation, ran the config checker and it checked out but didn’t work. As the file mentioned previously did work, is there a reason that there needs to be 2 files that do the same thing? Thanks 😊 From: Veeck ***@***.***> Sent: Monday, October 2, 2023 7:01 PM To: MichMich/MagicMirror-Documentation ***@***.***> Cc: 3DPixel ***@***.***>; Author ***@***.***> Subject: Re: [MichMich/MagicMirror-Documentation] Update compliments.md (PR #188) I edited the config/compliments.js file Strange filename, you should edit config/config.js — Reply to this email directly, view it on GitHub<#188 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGKWOMGG77YLSH2LSXWEHH3X5L6N5AVCNFSM6AAAAAA5NXFMLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBTGQ4TENRZHE>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[3DPixel]

Sorry, what is ‘lintered’, is that GitHub lingo? I’m new to GitHub so just getting to grips with it. Thanks From: Karsten Hassel ***@***.***> Sent: Monday, October 2, 2023 7:24 PM To: MichMich/MagicMirror-Documentation ***@***.***> Cc: 3DPixel ***@***.***>; Author ***@***.***> Subject: Re: [MichMich/MagicMirror-Documentation] Update compliments.md (PR #188) what is the content beside the unwanted filename change? It's hard to see, looks like only format has changed (which will be reverted when lintered). — Reply to this email directly, view it on GitHub<#188 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGKWOMCFTDASXBPC45FYJFDX5MBCXAVCNFSM6AAAAAA5NXFMLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBTGUZDGMRRG4>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>